Have search use search_raw and count use search - #91
Closed
Treora wants to merge 5 commits into
Closed
Conversation
Member
|
Love it. |
Member
|
Needs a quick rebase after I merged your other PR first. |
Treora
force-pushed
the
revise_search_raw
branch
from
August 19, 2014 22:44
bc7610e to
89b1a8c
Compare
Treora
force-pushed
the
revise_search_raw
branch
from
September 23, 2014 09:06
89b1a8c to
fde7bb1
Compare
Member
There was a problem hiding this comment.
I think it's okay to use search to implement count rather than the count call but let's update the kwargs with a limit of 0 so that the database isn't accessing the document source objects and serializing them back to us.
Contributor
Author
There was a problem hiding this comment.
Good point, thanks. Done.
Treora
force-pushed
the
revise_search_raw
branch
from
September 26, 2014 11:38
a592bc9 to
19af511
Compare
Member
|
Closing because I've removed the last commit and rebased and I'm going to move this to a branch on this fork and give @Treora push access. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's clean up this stuff.
Note this also allows passing keyword arguments for search_raw to search and count.