Don't pass kwargs everywhere, but do keep params to Elasticsearch.search separated - #102
Merged
Merged
Conversation
Merged
Contributor
Author
There was a problem hiding this comment.
Either **kwargs, or raw_results is needed. I doubted and opted for the former, or would you rather have arguments explicit when they are only used in the parent's class?
Member
There was a problem hiding this comment.
Yup, make raw_result explicit, I think.
Member
|
Just a couple of nitpicks -- also I'd prefer if you could make this a clean set of changes on top of current HEAD. There's no need for a revert commit. |
Treora
force-pushed
the
revise_search_raw2
branch
from
September 30, 2014 17:41
a40eda6 to
07f2dc4
Compare
Treora
force-pushed
the
revise_search_raw2
branch
from
September 30, 2014 17:43
07f2dc4 to
a0573f0
Compare
Member
|
LGTM. Merging. |
nickstenning
added a commit
that referenced
this pull request
Sep 30, 2014
Don't pass kwargs everywhere, but do keep params to Elasticsearch.search separated
Member
|
🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A combination of #91 and #101. As suggested in #101 (comment)