Skip to content

Drop Elasticsearch pre-1.0.0 compatibility mode - #92

Merged
tilgovi merged 1 commit into
openannotation:masterfrom
Treora:drop_compatibility_mode
Aug 19, 2014
Merged

Drop Elasticsearch pre-1.0.0 compatibility mode#92
tilgovi merged 1 commit into
openannotation:masterfrom
Treora:drop_compatibility_mode

Conversation

@Treora

@Treora Treora commented Aug 19, 2014

Copy link
Copy Markdown
Contributor

Objections? I'm just in a cleaning mood. :)

@Treora

Treora commented Aug 19, 2014

Copy link
Copy Markdown
Contributor Author

If we would want to keep the compatibility, we should also test it with older elasticsearch versions. I would be surprised if all recent changes work with older ES versions. Our compatibility_mode setting is in any case only used in a single place, for the count API. And that single place would be removed by #91, making it a bogus setting.

@tilgovi

tilgovi commented Aug 19, 2014

Copy link
Copy Markdown
Member

Works for me.

tilgovi added a commit that referenced this pull request Aug 19, 2014
Drop Elasticsearch pre-1.0.0 compatibility mode
@tilgovi
tilgovi merged commit ece7f66 into openannotation:master Aug 19, 2014
@Treora
Treora deleted the drop_compatibility_mode branch January 6, 2015 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants