[vcpkg baseline][opencv4] Add features to control hdf5 and tesseract dependencies, disable libiconv - #48492
Merged
Merged
Conversation
Kai Pastor (dg0yt)
force-pushed
the
opencv4
branch
2 times, most recently
from
November 26, 2025 23:02
71e241c to
471b37d
Compare
Billy O'Neal (BillyONeal)
previously requested changes
Nov 26, 2025
Kai Pastor (dg0yt)
force-pushed
the
opencv4
branch
from
November 26, 2025 23:09
471b37d to
1d54005
Compare
Contributor
Author
|
This is unexpected (vcpkg-ci-openimageio:arm64-osx): |
Kai Pastor (dg0yt)
force-pushed
the
opencv4
branch
from
November 29, 2025 08:46
2d4767e to
1221e62
Compare
This was referenced Nov 29, 2025
Each opencv[core,feature] maps to opencv4[feature] incl. default features.
Kai Pastor (dg0yt)
force-pushed
the
opencv4
branch
from
December 3, 2025 06:16
1221e62 to
bbf065d
Compare
11 tasks
Kai Pastor (dg0yt)
marked this pull request as ready for review
December 3, 2025 20:18
Comment on lines
-404
to
-405
| # 120 min build time for libjxl arm64-uwp-rel, reason unknown | ||
| libjxl:arm64-uwp=skip |
Contributor
Author
There was a problem hiding this comment.
I believe this is outdated.
Kai Pastor (dg0yt)
marked this pull request as draft
December 3, 2025 20:20
This comment was marked as resolved.
This comment was marked as resolved.
Kai Pastor (dg0yt)
marked this pull request as ready for review
December 3, 2025 20:22
|
|
||
| halide = skip | ||
| llvm = skip | ||
| opencv = skip # actual feature test is opencv4 |
There was a problem hiding this comment.
I think this will disable feature test for anything that depends on opencv as well?
Contributor
Author
There was a problem hiding this comment.
Maybe I have seen these other two skip lines too often, recently ;-)
There was a problem hiding this comment.
I'm not sure I understand but it seems ok now 🙃
Billy O'Neal (BillyONeal)
self-requested a review
December 3, 2025 22:00
7 tasks
Ian Reinhart Geiser (geiseri)
pushed a commit
to geiseri/vcpkg
that referenced
this pull request
Dec 18, 2025
…dependencies, disable libiconv (microsoft#48492)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potentially disruptive:
hdfortextinstead ofcontrib.Fix openimageio:arm64-windows-static-md baseline regression. Cf. https://dev.azure.com/vcpkg/public/_build/results?buildId=123745&view=logs&j=4df292c1-f579-5a84-c7d0-98b54b894473 et al.
(This is a change for system with iconv in libc. But for those systems users could still override the option via triplet. OTOH it would take at another extra feature to make libiconv an explicit option, controlling the LGPL dependency.)
Benefits:
contrib.contribfor platforms excluded by hdf5 or tesseract.vcpkg-ci-opencv=passrequirement in ci baseline for arm64 windows.Skipping opencv in feature tests because it adds CI time without adding significant value: Each feature maps to a feature in opencv4. For opencv4, features are already tested separately (
opencv4[core,<feature>]). But used as a dependency from opencv, default-features are added (opencv4[<feature>]), so the tests cannot share binary artifacts.