[onnxruntime] new ports for microsoft/onnxruntime v1.23.2 - #36850
Conversation
|
Hmm.. for some reason CMake tries old version of Xcode ... |
|
IIRC the xcode generator needs a GUI session, i.e. doesn't work in CI. |
|
Added notes for the current features. |
|
Can't fix the errors of the CUDA code. I will remove |
|
So the build error comes from arm_neon build.
Let me check the details... |
For NDK 25(Clang 14.0.7), I tried |
|
Kai Pastor (dg0yt)
left a comment
There was a problem hiding this comment.
A lot of work! 🚀
| if(("openvino" IN_LIST FEATURES) AND VCPKG_TARGET_IS_WINDOWS) | ||
| file(RENAME "${CURRENT_PACKAGES_DIR}/debug/lib/onnxruntime_providers_openvino.dll" "${CURRENT_PACKAGES_DIR}/debug/bin/onnxruntime_providers_openvino.dll") | ||
| file(RENAME "${CURRENT_PACKAGES_DIR}/lib/onnxruntime_providers_openvino.dll" "${CURRENT_PACKAGES_DIR}/bin/onnxruntime_providers_openvino.dll") | ||
| endif() |
There was a problem hiding this comment.
Renaming after install: Expected to break exported CMake config.
There was a problem hiding this comment.
The installation was fixed in microsoft/onnxruntime#19966
Use the latest release to apply the patch
| if(VCPKG_LIBRARY_LINKAGE STREQUAL "static") | ||
| file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/bin" "${CURRENT_PACKAGES_DIR}/bin") | ||
| endif() |
There was a problem hiding this comment.
Are these dirs empty? Or are there programs which need to be handled regardless of linkage?
There was a problem hiding this comment.
I guess there might some tool build based on features, but they are not defined in this port version.
|
Hi, requesting a review and a tag for it |
|
Almost there, you rock guys 💪 |
|
Billy O'Neal (@BillyONeal) I think the remaining build fail is unrelated to this PR |
|
I agree that looks like a baseline issue /cc Victor Romero (@vicroms) |
This is independent of this PR: Missing installation order control in wechat_qrcode in |
|
Kai Pastor (@dg0yt) That seems correct to me. I'm pinging Victor Romero (@vicroms) though because as the most recent pusher I am unable to merge :( |
2c9fdb8
into
microsoft:master
|
Sorry for taking this long. There was a series of suffering in my life after opening this PR. Thankfully it didn't crush me. |
Thank you very much for your work! 👍 |
|
These are two different packages:
Don't use onnxruntime-gpu, this is just a wrapper for backward compatibility. |
You're right, that explains my remarks 1) and 3) - and I was already using the However the root issue remains with the "schemes already registered" errors. Perhaps onnx is not built with ONNX_DISABLE_STATIC_REGISTRATION=ON? |
|
Patrik Huber (@patrikhuber) I encountered this issue a long time ago; please see my comment |
I saw this yesterday actually, but I was assuming this was long fixed before this PR was merged. So are we essentially saying then that a non-functioning PR was merged because that issue was never fixed? It's an issue that only becomes apparent when one tries to run onnxruntime, so it wouldn't have been caught by vcpkg's CI checks, obviously. As far as I can see, #38879 was a proposed solution, but it was not merged. |
|
Patrik Huber (@patrikhuber) So I chose to use an overlay port, that way I have greater autonomy |
|
AFAIU:
|
I was not able to inject |
|
https://learn.microsoft.com/en-us/vcpkg/users/triplets#per-port-customization + if(PORT STREQUAL "onnx")
list(APPEND VCPKG_CMAKE_CONFIGURE_OPTIONS "-DONNX_DISABLE_STATIC_REGISTRATION=1")
endif()(Untested.) |
There is an unmerged PR for this since some years: microsoft/onnxruntime#12505 |

Notes
With my experience in the registry, Some features may not work well with toolchain.
Hope more feature contributions after this work.
References
ONNXRuntime
eigen33.4.0 in vcpkg)microsoft/vcpkg
onnxonnxruntime-gpunvidia-cutlassluncliff/vcpkg-registry
Checklist
find_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.