[vulkan, spirv, etc] Update to v1.4.328 - #48304
Conversation
|
Kai Pastor (@dg0yt) nice to see you again 😅 this is draft for the moment mostly because i'm just stepwise restarting #46621, to see if i can get away now with a more minimal set of changes. if i get the CI checks to go all-green then i'll clean things up and do some PR diligence. |
461f2cb to
d6cbdca
Compare
|
From what I can see, vulkan-validationlayers switched their dependency from robin-hood-hashing to parallel-hashmap in 1.4.313 ( |
69a7e4b to
ed473d4
Compare
…ssary libs installed
ed473d4 to
26e2e56
Compare
Andrew Tribick (@ajtribick), i swapped the dependencies, but it really feels like I should have to do something else as well - I was surprised that nothing broke with just a straight swap. Indeed, simply removing both |
|
Kai Pastor (@dg0yt) marking this as ready-for-review. |
|
Please merge with master and fix the resulting build failures. |
|
The issue I see is that it uses the vendored parallel-hashmap natvis file here: https://github.com/KhronosGroup/Vulkan-ValidationLayers/blob/a1ff2dbc7e50828def8098c5ebf0fee10b714f85/layers/CMakeLists.txt#L477 The parallel-hashmap port does actually install this file, so maybe that can be used instead: |
|
don't want to merge it in because it looks like it's still in flux, but waiting on this PR for #48492 |
2198b3e to
a881457
Compare
|
this should.... finally... be ready. |
Victor Romero (vicroms)
left a comment
There was a problem hiding this comment.
Almost there, one merge issue on ports version db history.
|
🥳 |
./vcpkg x-add-version --alland committing the result.