[Mike Griese (zadjii-msft)]

Summary of the Pull Request

New year, new unittests.

This PR introduces a new project, TestHostApp. This project is largely taken from the TAEF samples, and allows us to easily construct a helper executable and resources.pri for running TerminalApp unittests.

References

PR Checklist

• Closes Figure out how to test our .xaml classes #3986
• I work here
• is Tests
• [n/a] Requires documentation to be updated
• Waiting for an updated version of TAEF to be available

Detailed Description of the Pull Request / Additional comments

Unittesting for the TerminalApp project has been a horrifying process to try getting everything pieced together just right. Dependencies need to get added to manifests, binplaced correctly, and XAML resources need to get compiled together as well. In addition, using a MUX Application (as opposed to the Windows.UI.Xaml Application) has led to additional problems.

This was always a horrifying house of cards for us. Turns out, the reason this was so horrible is that the test infrastructure for doing what we're doing literally didn't exist when I started doing all that work last year.

So, with help from the TAEF team, I was able to get rid of our entire house of cards, and use a much simpler project to build and run the tests.

Unfortunately, the latest TAEF release has a minor bug in it's build rules, and only publishes the x86 version of a dll we need from them. But, the rest of this PR works for x86, and I'll bump this when that updated version is available. We should be able to review this even in the state it's in.

Validation Steps Performed

ran the tests yo

[Dustin L. Howett (MSFT) (DHowett-MSFT)]

Please check the .vssettings file to make sure the C++/CLI workload is actually installed ...

[Dustin L. Howett (MSFT) (DHowett-MSFT)]

or, requested. otherwise, people will not be able to build our solution.

[Mike Griese (zadjii-msft)]

I just dumped my own .vsconfig, and I didn't see anything that looked like it. From diff --color .vsconfig ../../../Documents/.vsconfig:

Details

6,9c6
<     "Microsoft.VisualStudio.Workload.Universal",
<     "Microsoft.VisualStudio.Workload.NativeDesktop",
<     "Microsoft.VisualStudio.Workload.ManagedDesktop",
<     "Microsoft.VisualStudio.Component.ManagedDesktop.Prerequisites",
---
>     "Microsoft.NetCore.Component.SDK",
10a8
>     "Microsoft.Net.Component.4.6.1.TargetingPack",
12a11,18
>     "Microsoft.VisualStudio.Component.FSharp",
>     "Microsoft.NetCore.Component.DevelopmentTools",
>     "Microsoft.VisualStudio.Component.FSharp.WebTemplates",
>     "Microsoft.VisualStudio.ComponentGroup.WebToolsExtensions",
>     "Microsoft.VisualStudio.Component.DockerTools",
>     "Microsoft.NetCore.Component.Web",
>     "Microsoft.Net.Component.4.8.SDK",
>     "Microsoft.Net.Component.4.7.2.TargetingPack",
13a20,22
>     "Microsoft.VisualStudio.Component.TypeScript.3.7",
>     "Microsoft.VisualStudio.Component.JavaScript.TypeScript",
>     "Microsoft.VisualStudio.Component.JavaScript.Diagnostics",
14a24,32
>     "Microsoft.VisualStudio.Component.TextTemplating",
>     "Component.Microsoft.VisualStudio.RazorExtension",
>     "Microsoft.VisualStudio.Component.IISExpress",
>     "Microsoft.VisualStudio.Component.SQL.ADAL",
>     "Microsoft.VisualStudio.Component.SQL.LocalDB.Runtime",
>     "Microsoft.VisualStudio.Component.Common.Azure.Tools",
>     "Microsoft.VisualStudio.Component.SQL.CLR",
>     "Microsoft.VisualStudio.Component.MSODBC.SQL",
>     "Microsoft.VisualStudio.Component.MSSQL.CMDLnUtils",
16c34
<     "Microsoft.Net.Component.4.TargetingPack",
---
>     "Microsoft.Net.Component.4.5.2.TargetingPack",
17a36,51
>     "Microsoft.VisualStudio.Component.SQL.SSDT",
>     "Microsoft.VisualStudio.Component.SQL.DataSources",
>     "Component.Microsoft.Web.LibraryManager",
>     "Microsoft.VisualStudio.ComponentGroup.Web",
>     "Microsoft.VisualStudio.Component.Web",
>     "Microsoft.VisualStudio.Component.IntelliCode",
>     "Microsoft.Net.Component.4.TargetingPack",
>     "Microsoft.Net.Component.4.5.1.TargetingPack",
>     "Microsoft.Net.Component.4.6.TargetingPack",
>     "Microsoft.Net.ComponentGroup.TargetingPacks.Common",
>     "Microsoft.Net.Core.Component.SDK.2.1",
>     "Microsoft.VisualStudio.Component.Azure.Compute.Emulator",
>     "Microsoft.VisualStudio.Component.Azure.ClientLibs",
>     "Microsoft.VisualStudio.Component.Azure.AuthoringTools",
>     "Microsoft.VisualStudio.Component.Debugger.TimeTravel",
>     "Microsoft.VisualStudio.Component.IntelliTrace.FrontEnd",
19,21c53,63
<     "Microsoft.VisualStudio.Component.Debugger.JustInTime",
<     "Microsoft.VisualStudio.Component.Windows10SDK.18362",
<     "Microsoft.VisualStudio.ComponentGroup.UWP.Support",
---
>     "Microsoft.VisualStudio.Component.EntityFramework",
>     "Microsoft.VisualStudio.Component.LiveUnitTesting",
>     "Microsoft.VisualStudio.Component.AppInsights.Tools",
>     "Microsoft.VisualStudio.Component.WebDeploy",
>     "Component.Microsoft.VisualStudio.LiveShare",
>     "Microsoft.VisualStudio.Component.ClassDesigner",
>     "Microsoft.VisualStudio.Component.GraphDocument",
>     "Microsoft.VisualStudio.Component.CodeMap",
>     "Microsoft.Component.PythonTools",
>     "Microsoft.Component.PythonTools.Miniconda",
>     "Microsoft.Component.PythonTools.Web",
22a65,78
>     "Microsoft.VisualStudio.Component.Windows10SDK",
>     "Microsoft.VisualStudio.Component.VC.Tools.x86.x64",
>     "Microsoft.VisualStudio.Component.Graphics.Tools",
>     "Microsoft.VisualStudio.Component.VC.DiagnosticTools",
>     "Microsoft.VisualStudio.Component.Windows10SDK.18362",
>     "Component.CPython3.x64",
>     "Microsoft.VisualStudio.Workload.Python",
>     "Microsoft.VisualStudio.Component.ManagedDesktop.Prerequisites",
>     "Microsoft.ComponentGroup.Blend",
>     "Microsoft.VisualStudio.Component.Debugger.JustInTime",
>     "Microsoft.VisualStudio.ComponentGroup.MSIX.Packaging",
>     "Microsoft.VisualStudio.Workload.ManagedDesktop",
>     "Microsoft.VisualStudio.Component.VC.Redist.14.Latest",
>     "Microsoft.VisualStudio.ComponentGroup.ArchitectureTools.Native",
23a80,89
>     "Microsoft.VisualStudio.ComponentGroup.WebToolsExtensions.CMake",
>     "Microsoft.VisualStudio.Component.VC.CMake.Project",
>     "Microsoft.VisualStudio.Component.VC.ATL",
>     "Microsoft.VisualStudio.Component.VC.TestAdapterForBoostTest",
>     "Microsoft.VisualStudio.Component.VC.TestAdapterForGoogleTest",
>     "Microsoft.VisualStudio.Component.Windows10SDK.17763",
>     "Microsoft.Component.VC.Runtime.UCRTSDK",
>     "Microsoft.VisualStudio.Workload.NativeDesktop",
>     "Microsoft.Component.NetFX.Native",
>     "Microsoft.VisualStudio.ComponentGroup.UWP.NetCoreAndStandard",
25,26c91,92
<     "Microsoft.VisualStudio.Component.VC.Redist.14.Latest",
<     "Microsoft.VisualStudio.Component.VC.Tools.x86.x64",
---
>     "Microsoft.VisualStudio.ComponentGroup.UWP.Xamarin",
>     "Microsoft.VisualStudio.ComponentGroup.UWP.Support",
28,29c94,95
<     "Microsoft.VisualStudio.Component.VC.v142.x86.x64",
<     "Microsoft.VisualStudio.Component.VC.v142.ARM64",
---
>     "Microsoft.VisualStudio.Component.UWP.VC.ARM64",
>     "Microsoft.VisualStudio.Component.VC.Tools.ARM",
31,32c97,101
<     "Microsoft.VisualStudio.ComponentGroup.UWP.VC.v142",
<     "Microsoft.VisualStudio.Component.UWP.VC.ARM64"
---
>     "Microsoft.VisualStudio.Workload.Universal",
>     "Microsoft.VisualStudio.Workload.NetCoreTools",
>     "Microsoft.NetCore.ComponentGroup.DevelopmentTools.2.1",
>     "Microsoft.NetCore.ComponentGroup.Web.2.1",
>     "Microsoft.Net.Component.4.7.2.SDK"
34c103
< }
---
> }

[Michael Niksa (miniksa)]

I don't have anything else to really complain about here, but please make sure Dustin L. Howett (MSFT) (@DHowett-MSFT) is the other signer on this because he has a few outstanding threads left still open.

[Deleted user (ghost)]

Hello Mike Griese (@zadjii-msft)!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.