Skip to content

TerminalApp.Unit.Tests should have its SxS manifest auto-generated like WindowsTerminal #2095

New issue
New issue
Closed
Closed
TerminalApp.Unit.Tests should have its SxS manifest auto-generated like WindowsTerminal#2095
Labels
Area-BuildIssues pertaining to the build system, CI, infrastructure, metaHelp WantedWe encourage anyone to jump in on these.Issue-TaskIt's a feature request, but it doesn't really need a major design.Needs-Tag-FixDoesn't match tag requirementsProduct-TerminalThe new Windows Terminal.
Milestone
Terminal v1.0

Description

@zadjii-msft
Mike Griese (zadjii-msft)
opened on Jul 25, 2019

I'm not sure why, but the bcz build itself seems to keep changing this file. Should I leave the changes? They seem similar to changes that were manually done in PR #2043 so I hope they're not bad.

Originally posted by Michael Ratanapintha (@metathinker) in https://github.com/microsoft/terminal/pull/2050/files

Since WindowsTerminal.manifest is empty now, and auto-generated, we'll need to also auto-generate the manifest for the tests for SxS WinRT activation.

Activity

  1. ghost added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Jul 25, 2019
  2. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Jul 25, 2019

  3. zadjii-msft commented on Jul 25, 2019

    @zadjii-msft
    Mike Griese (zadjii-msft)
    on Jul 25, 2019
    MemberAuthor

    This is also related to #1210.

    This matters for the "SettingsTests".

  4. Dustin L. Howett (MSFT) (DHowett-MSFT)
    added
    Area-BuildIssues pertaining to the build system, CI, infrastructure, meta
    Help WantedWe encourage anyone to jump in on these.
    Issue-TaskIt's a feature request, but it doesn't really need a major design.
    Product-TerminalThe new Windows Terminal.
    and removed
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Jul 29, 2019
  5. ghost removed
    Needs-Tag-FixDoesn't match tag requirements
    on Jul 29, 2019
  6. Dustin L. Howett (MSFT) (DHowett-MSFT)
    added this to the Terminal Backlog milestone on Jul 29, 2019
  7. Mike Griese (zadjii-msft)
    modified the milestones: Terminal Backlog, Terminal v1.0 on Aug 10, 2019

  8. zadjii-msft commented on Aug 16, 2019

    @zadjii-msft
    Mike Griese (zadjii-msft)
    on Aug 16, 2019
    MemberAuthor

    This should have honestly been done at the same time as #2294. The stuff that the LocalTests project does is exactly what this issue is talking about doing.

  9. zadjii-msft commented on Jan 23, 2020

    @zadjii-msft
    Mike Griese (zadjii-msft)
    on Jan 23, 2020
    MemberAuthor

    Hey I did this with #4105! Or more correctly, we don't need to do this anymore, now that the localtests are magic.

  10. Mike Griese (zadjii-msft)
    closed this as completedon Jan 23, 2020
  11. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-BuildIssues pertaining to the build system, CI, infrastructure, metaHelp WantedWe encourage anyone to jump in on these.Issue-TaskIt's a feature request, but it doesn't really need a major design.Needs-Tag-FixDoesn't match tag requirementsProduct-TerminalThe new Windows Terminal.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions