Repository navigation
Guard the substring calls in StateMachine parser to avoid bounds issues - #4202
Merged
1 commit merged intoJan 14, 2020
Merged
1 commit merged into
1 commit merged into
Conversation
Michael Niksa (miniksa)
force-pushed
the
dev/miniksa/fail_tests
branch
2 times, most recently
from
January 13, 2020 23:21
8548d55 to
4fd3de5
Compare
Contributor
|
Michael Niksa (@miniksa) After resolving a conflict, #4105 was merged in. Then I faced the trouble with the x86 tests. |
Michael Niksa (miniksa)
requested review from
Dustin L. Howett (MSFT) (DHowett-MSFT) and
Mike Griese (zadjii-msft)
and removed request for
Dustin L. Howett (MSFT) (DHowett-MSFT)
January 14, 2020 00:04
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Dustin L. Howett (MSFT) (@DHowett-MSFT), seems fine (TM) |
Michael Niksa (miniksa)
force-pushed
the
dev/miniksa/fail_tests
branch
from
January 14, 2020 00:14
f0e6a38 to
7c4570f
Compare
Contributor
Author
|
k, push forced back to just the change on master. |
Michael Niksa (miniksa)
marked this pull request as ready for review
January 14, 2020 00:20
Michael Niksa (miniksa)
requested review from
Carlos Zamora (carlos-zamora) and
Leon Liang (leonMSFT)
January 14, 2020 00:20
Michael Niksa (miniksa)
changed the title
Carlos Zamora (carlos-zamora)
approved these changes
Jan 14, 2020
Dustin L. Howett (MSFT) (DHowett-MSFT)
approved these changes
Jan 14, 2020
Contributor
|
@msftbot merge this in 5 minutes |
ghost
added
the
AutoMerge
|
Hello Dustin L. Howett (MSFT) (@DHowett-MSFT)! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
deleted the
dev/miniksa/fail_tests
branch
January 14, 2020 00:46
2 of 5 tasks
Dustin L. Howett (MSFT) (DHowett-MSFT)
pushed a commit
that referenced
this pull request
Jan 24, 2020
## Summary of the Pull Request Perform checking on `std::basic_string_view<T>.substr()` calls to prevent running out of bounds and sporadic Privileged Instruction throws during x86 tests. ## PR Checklist * [x] Closes the x86 tests failing all over the place since #4125 for no apparent reason * [x] I work here * [x] Tests pass ## Detailed Description of the Pull Request / Additional comments It appears that not all `std::basic_string_view<T>.substr()` calls are created equally. I rooted around for other versions of the code in our source tree and found several versions that were less careful about checking the start position and the size than the one that appears when building locally on dev machines. My theory is that one of these older versions is deployed somewhere in the CI. Instead of clamping down the size parameter appropriately or throwing correctly when the position is out of bounds, I believe that it's just creating a substring with a bad range over an invalid/uninitialized memory region. Then when the test operates on that, sometimes it turns out to trigger the privileged instruction NTSTATUS error we are seeing in CI. ## Test Procedure 1. Fixed the thing 2. Ran the CI and it worked 3. Reverted everything and turned off all of the CI build except just the parser tests (and supporting libraries) 4. Ran CI and it failed 5. Put the fix back on top (cherry-pick) 6. It worked. 7. Ran it again. 8. It worked. 9. Turn all the rest of the CI build back on (cherry picked from commit 4129ceb)
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Perform checking on
std::basic_string_view<T>.substr()calls toprevent running out of bounds and sporadic Privileged Instruction throws
during x86 tests.
PR Checklist
apparent reason
Detailed Description of the Pull Request / Additional comments
It appears that not all
std::basic_string_view<T>.substr()calls arecreated equally. I rooted around for other versions of the code in our
source tree and found several versions that were less careful about
checking the start position and the size than the one that appears when
building locally on dev machines.
My theory is that one of these older versions is deployed somewhere in
the CI. Instead of clamping down the size parameter appropriately or
throwing correctly when the position is out of bounds, I believe that
it's just creating a substring with a bad range over an
invalid/uninitialized memory region. Then when the test operates on
that, sometimes it turns out to trigger the privileged instruction
NTSTATUS error we are seeing in CI.
Test Procedure
the parser tests (and supporting libraries)