Repository navigation
Copy RTF data to the clipboard - #3535
Conversation
Carlos Zamora (carlos-zamora)
left a comment
There was a problem hiding this comment.
Awesome! Thanks! I feel like there's a way to share code between GenHTML() and GenRTF() but I don't think that's worth blocking over. I created #3538 to track that.
Dustin L. Howett (MSFT) (@DHowett-MSFT) Thoughts on bringing this into ConHost too? I feel like that'd be a separate PR but definitely relevant.
|
Yes, this will be cool for conhost. |
Mike Griese (zadjii-msft)
left a comment
There was a problem hiding this comment.
This looks great to me. Thanks for doing this!
|
Anirudh Rayabharam (@anirudhrb) it looks like the code formatting check is failing - could you run |
Dustin L. Howett (MSFT) (@DHowett-MSFT) Carlos Zamora (@carlos-zamora) What needs to be done to bring this into conhost? Are you gonna create a new issue? |
|
Followup filed at #3560. No need to do it in this one. 😄 |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
🎉 Handy links: |
Summary of the Pull Request
RTF data is now copied to the clipboard. Tested by copy pasting text from terminal to WordPad.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Mostly similar to PR #1224. Added a new static method
GenRTFinTextBufferthat is responsiblefor generating the RTF representation of a given text. The generated RTF is added to the
DataPackagethat is ultimately passed to the clipboard.Validation Steps Performed
Validated by copy pasting text from the terminal to WordPad. Validated with different colors to make sure that is working. (MS Word seems to prefer HTML data from the clipboard instead of RTF.)