You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Refactor GenRTF() and GenHTML() to use shared components #3538
#3535 adds GenRTF() to enable RTF Copy. It has some parts that are very similar to GenHTML(), which makes sense. It'd be nice to find a way to refactor the code a bit to reuse some sections.
My concern is that we make find a bug and fix it in one and not the other.
We could probably use a few helper methods to create a more distinct separation of HTML vs RTF specific portions. The overall architecture and flow of both functions are essentially the same. Maybe even add an enum?
Dustin L. Howett (@DHowett) I was taking a closer look at the differences between GenRTF() and GenHTML(). Refactoring them would just make the code more difficult to understand and risks breaking something. Mind if I just close this issue?
Activity
carlos-zamora commentedon Jun 2, 2020
Dustin L. Howett (@DHowett) I was taking a closer look at the differences between
GenRTF()andGenHTML(). Refactoring them would just make the code more difficult to understand and risks breaking something. Mind if I just close this issue?DHowett commentedon Jun 2, 2020
Go ahead!