Connect GenRTF to conhost (Win32Interactivity Clipboard) #3560

Activity

1. ghost added

   Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting

   on Nov 13, 2019
2. ghost added

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   on Nov 13, 2019
3. Dustin L. Howett (MSFT) (DHowett-MSFT)

   added

   Area-InteractionInteracting with the vintage console window (as opposed to driving via API or hooks)Interacting with the vintage console window (as opposed to driving via API or hooks)

   Help WantedWe encourage anyone to jump in on these.We encourage anyone to jump in on these.

   Issue-TaskIt's a feature request, but it doesn't really need a major design.It's a feature request, but it doesn't really need a major design.

   Product-ConhostFor issues in the Console codebaseFor issues in the Console codebase

   on Nov 13, 2019
4. ghost removed

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   on Nov 13, 2019
5. Dustin L. Howett (MSFT) (DHowett-MSFT)

   added

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   and removed

   Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting

   on Nov 13, 2019
6. ghost removed

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   on Nov 13, 2019
7. Dustin L. Howett (MSFT) (DHowett-MSFT)

   added this to the 21H1 milestone on Nov 13, 2019
8. anirudhrb commented on Nov 14, 2019

   

   Anirudh Rayabharam (anirudhrb)

   on Nov 14, 2019

   Contributor

   More actions

   I would like to pick this up too!

   I believe this is the file I should be looking at: https://github.com/microsoft/terminal/blob/master/src/interactivity/win32/Clipboard.cpp

   At a high-level, I should do the same things that are being done for HTML copy right?

   Also, we are registering a format for HTML here:
   

   terminal/src/interactivity/win32/Clipboard.cpp

   Line 303 in 13406b7

   UINT const CF_HTML = RegisterClipboardFormatW(L"HTML Format");

   The way I understand it, any other program that wants to read this HTML needs to know that format name is HTML Format. Similarly, is there some standard name for RTF? Is it simply RTF Format? Do we document these names somewhere?

   Let me know if I'm on the right track here.
9. DHowett-MSFT commented on Nov 14, 2019

   

   Dustin L. Howett (MSFT) (DHowett-MSFT)

   on Nov 14, 2019

   ContributorAuthor

   More actions

   You’re on the right track! I’ll assign this to you.

   I’m not sure what the legacy clipboard API contract is for RTF content, but figuring that out is half the fun!
10. Dustin L. Howett (MSFT) (DHowett-MSFT)

    assigned

    Anirudh Rayabharam (anirudhrb)

    on Nov 14, 2019
11. DHowett-MSFT commented on Nov 14, 2019

    

    Dustin L. Howett (MSFT) (DHowett-MSFT)

    on Nov 14, 2019

    ContributorAuthor

    More actions

    To trigger formatted copy in conhost, you’ll want to hold down Alt when you issue the final right-click that performs the copy. It’s not “on by default” like Terminal’s is.
12. ghost added

    In-PRThis issue has a related PRThis issue has a related PR

    on Nov 15, 2019
13. anirudhrb commented on Nov 15, 2019

    

    Anirudh Rayabharam (anirudhrb)

    on Nov 15, 2019

    Contributor

    More actions

    Dustin L. Howett (MSFT) (@DHowett-MSFT) raised a PR (#3595) for this. Please review.
14. ghost closed this as completedin #3595on Dec 5, 2019
15. ghost added a commit that references this issue on Dec 5, 2019

    Conhost: copy RTF to clipboard (#3595)

    ...

    This issue will close once commit f1ff0cf is merged into the 'main' branch.

    f1ff0cf
16. ghost removed

    In-PRThis issue has a related PRThis issue has a related PR

    on Dec 5, 2019
17. ghost added

    Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Fix is checked in, but it might be 3-4 weeks until a release.

    on Dec 5, 2019