Re-enable TerminalApp tests SettingsTests and TabsTests #1210

Activity

1. Mike Griese (zadjii-msft)

   added

   Product-TerminalThe new Windows Terminal.The new Windows Terminal.

   Issue-TaskIt's a feature request, but it doesn't really need a major design.It's a feature request, but it doesn't really need a major design.

   Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.

   on Jun 11, 2019
2. Mike Griese (zadjii-msft)

   added this to the Terminal v1.0 milestone on Jun 11, 2019
3. ghost added

   Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting

   on Jun 11, 2019
4. Dustin L. Howett (MSFT) (DHowett-MSFT)

   removed

   Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting

   on Jun 13, 2019
5. zadjii-msft commented on Jul 25, 2019

   

   Mike Griese (zadjii-msft)

   on Jul 25, 2019

   MemberAuthor

   More actions

   We might be able to re-enable the SettingsTests without re-enabling the TabTests. The TabTests rely on XAML Islands, which isn't supported on the build machines. the TabTests require deploying a appx on the test machine, but we can't just skip the test if the build machine isn't a high enough version.

   However, since the SettingsTests only rely on SxS activation, we might be able to check the version in the CLASS_SETUP, and skip the test if the machine isn't the right version.
6. ghost added

   In-PRThis issue has a related PRThis issue has a related PR

   on Aug 6, 2019
7. Mike Griese (zadjii-msft)

   closed this as completedin #2294on Aug 13, 2019
8. ghost added

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   on Aug 13, 2019
9. ghost removed

   In-PRThis issue has a related PRThis issue has a related PR

   on Aug 13, 2019
10. ghost added

    Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Fix is checked in, but it might be 3-4 weeks until a release.

    on Aug 13, 2019