Repository navigation
refactor(actions): move the synced comment and machine-path composites to their convention names - #675
Merged
Conversation
…s to their convention names Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
kyle-sexton
marked this pull request as ready for review
October 4, 2026 13:55
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a044c21f2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…eir new dirs Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
kyle-sexton
added a commit
that referenced
this pull request
Oct 4, 2026
No related issue: Phase 5 plan step (shared Dependabot auto-merge reusable R); tracked in the actions-conventions plan, not an issue. ## Summary Adds `.github/workflows/pr-automerge-dependabot.yml`, a `workflow_call` reusable that arms GitHub squash auto-merge on low-risk Dependabot PRs. GitHub then merges once `ci-status` and every other required check pass. It implements standards `components/dependabot-policy/policy.json` `autoMerge` (`github-actions`; `actions/*`, `github/*`, `anthropics/*`; no semver-major; `ci-status`). ## Fix - Gates, all required: event is `pull_request`; PR author id `49699333` (dependabot[bot]); event sender (`github.event.sender.id`, the pusher) is `49699333`; fetch-metadata succeeded, and failed, empty or invalid metadata is a skip; every update's ecosystem is `github_actions`; every dependency name matches the case-sensitive allowlist glob; every update is semver patch or minor (grouped PRs included; an uncomputable type skips); every PR commit, head included, has author `49699333`, committer `19864447` (web-flow) and a signature verified with reason `valid`. That commit shape matches live Dependabot commits on medley#2094 and ci-workflows #651, #655 and #674. - fetch-metadata is `continue-on-error`, and the gate step runs on `!cancelled()`. A force-push that makes fetch-metadata fail therefore still reaches the disarm. - Arms with `enablePullRequestAutoMerge(mergeMethod: SQUASH, expectedHeadOid: <verified head>)`. No direct-merge fallback, so nothing merges around `ci-status`. - A skipped PR that was armed on an earlier head is disarmed (GitHub keeps auto-merge on after a push by a write-access user). - No checkout; PR-derived values reach the script via `env:` only. Job permissions: `contents: write`, `pull-requests: write`. Input: `runner` (default `ubuntu-24.04`). - The gate runs inline in `actions/github-script` because a reusable has no ci-workflows checkout. `.github/scripts/pr-automerge-dependabot.test.cjs` extracts the script and runs it against fixtures, picked up by `test-contracts` (`node --test .github/scripts/*.test.cjs`). - README entry with the canonical caller. ## Verification - `node --test .github/scripts/*.test.cjs`: 219 pass, 0 fail (27 in the new file: vendor patch armed, vendor major, community patch, mixed group, vendor group with one major, non-Dependabot author, non-Dependabot sender, foreign head commit, forged author with a non-web-flow committer, unsigned commit, non-`valid` reason, moved head, non-actions ecosystem, lookalike owner, `Actions/checkout` case variant, empty and invalid metadata, failed metadata fetch disarmed, disarm). - Mutation spot-checks (unanchored glob, head-moved check, disarm, signature, committer, reason, sender, metadata outcome, continue-on-error) each turn a test red. - actionlint 1.7.12 and zizmor 1.30.0 clean on the new workflow; markdownlint and typos clean. - naming-lint `--mode enforcing` exits 0 after merging origin/main (#675). ## Related - Phase 5 plan Phase 3 (R). Next: Fable review, a minor release, then the standards `approvedReusableWorkflowContracts` entry and the allowlist lockstep test (separate PRs). - Ports medley `.github/workflows/dependabot-automerge.yml`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No related issue: convention-driven path rename tracked by the org rename map.
Summary
Moves
.github/actions/comment-hygienetocheck-comment-markersand.github/actions/machine-specific-pathstocheck-machine-paths, per standardsrename-map.json.Fix
git mvof both directories; path references updated inpr-run-checks.yml,pr-require-checks.yml,README.mdandci-fanout-consolidation.test.cjs. Workflow_call input names, compositename:values and script file names are unchanged (as in #669).Verification
$/placeholder findings.planjob id in maintenance-sync-standards.yml).Related
🤖 Generated with Claude Code