Repository navigation
refactor: rename workflows and actions to the org naming convention - #669
Merged
Merged
Conversation
Move every mapped ci-workflows workflow and composite action to its standards rename-map path, set each workflow name to its file stem, apply the job-id renames, and point reusables at their own actions with `$/`. The comment-hygiene and machine-specific-paths action directories are standards-synced and stay at their old paths until the sync destinations move. The three -self callers are untouched apart from local reusable paths and are folded in a follow-up commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…jobs Replace the three -self caller workflows with jobs in pr-require-checks.yml: pr-review, pr-review-security and intake-label-needs-triage. Each keeps the permissions and the one named secret its -self file passed, and pins the reusable's old path at the v0.33.0 merged SHA; they are repinned to the new paths once this change merges. None of them is in ci-status. Add ready_for_review to the pull_request types and an issues trigger. Every job except intake-label-needs-triage, ci-status included, now guards on github.event_name != 'issues' ahead of the unchanged contract-only gate; the two review jobs also require a pull_request event. Delete test-composites-head: pr-run-checks.yml reaches its composites through $/, so the dogfood call already runs them at the commit under test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reference comment-hygiene and machine-specific-paths with $/ like every other composite, so all of them resolve from the release that calls them, and drop the header comment about pin lag and composites-head. Format two test files that the rename left unformatted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ts the self callers ran on The folded pr-review and pr-review-security jobs also ran on edited, labeled and unlabeled events from fork pull requests. Restrict them to opened, synchronize, reopened and ready_for_review, and rename the README caller examples to the slot job ids. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b2f99f91a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The jsonschema lane's bash glob did not reach the two actions moved under .github/actions/pr-require-checks/, so the ci-status actions skipped schema validation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kyle-sexton
added a commit
that referenced
this pull request
Oct 4, 2026
…ths (#670) No related issue: Phase 4 follow-up of the GitHub Actions conventions program (tracking: melodic-software/standards#672) ## Summary The dogfood jobs folded into `pr-require-checks.yml` by #669 still called the old reusable paths at v0.33.0. This repins them to the renamed reusables at v0.34.0. This is the first run of `pr-review`, `pr-review-security` and `intake-label-needs-triage` at their new paths, and of their `$/` composite references from a caller pin. ## Fix - `pr-review` → `.github/workflows/pr-review.yml@7446b51 # v0.34.0`; `pr-review-security` → `pr-review-security.yml`; `intake-label-needs-triage` → `intake-label-needs-triage.yml`. No `workflow_call` input, output or secret changed between v0.33.0 and v0.34.0. - The two review jobs also run on a base-branch `edited` event. That event starts a full run that cancels an in-flight review through the shared concurrency group, so without this the head never got a review. The post-merge review of #669 found this. ## Verification - `node --test .github/scripts/*.test.cjs`: 192/192. - `actionlint`: no findings beyond the waived `$/` refs. - This PR's own `pr-review` and `pr-review-security` runs exercise the v0.34.0 reusables. ## Related - #669 (rename) and release v0.34.0. - melodic-software/standards#672 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
kyle-sexton
added a commit
to melodic-software/standards
that referenced
this pull request
Oct 4, 2026
…0.34.0 reusables (#683) No related issue: the contract step of the Actions naming migration; the rename and release are tracked through the PRs under Related. ## Summary ci-workflows v0.34.0 (`7446b51`) renamed eight reusable workflows. A reusable workflow at a new path has no runner-policy contract, so no consumer repo can call it yet. This adds one `approvedReusableWorkflowContracts` entry per renamed path at `7446b51`. | Old path | New path | |---|---| | `checks.yml` | `pr-run-checks.yml` | | `claude-intake-triage.yml` | `intake-triage.yml` | | `claude-review.yml` | `pr-review.yml` | | `claude-security-review.yml` | `pr-review-security.yml` | | `issue-triage-label.yml` | `intake-label-needs-triage.yml` | | `osv-scanner.yml` | `pr-scan-dependencies.yml` | | `standards-sync.yml` | `maintenance-sync-standards.yml` | | `zizmor.yml` | `pr-audit-workflows.yml` | ## Fix Each new entry is copied verbatim from the old path's contract at the SHA that was last reviewed. The diff between that SHA and `7446b51` changes no inputs, secrets, permissions or runner input. Each diff was hand-reviewed and approved on 2026-10-04. Four rows also carry pin changes outside the rename, and all four were approved: - `pr-review.yml`, `pr-review-security.yml`: `anthropics/claude-code-action` v1.0.235 → v1.0.240 (`ed670b4`, matches the upstream tag). - `pr-audit-workflows.yml`: `github/codeql-action/upload-sarif` v4.38.0 → v4.38.1 (`1c5b675`, matches the upstream tag). - `pr-run-checks.yml`: its composites now resolve through `$/` at `7446b51` instead of being pinned to v0.27.0. The old keys stay, so consumers pinned to v0.33.0 or earlier keep resolving. The diff only adds lines: 111 insertions, 0 deletions. ## Verification - `npm run lint:runner-policy`: Runner policy passed. - `node --test components/runner-policy/runner-policy.test.mjs`: 296 pass, 0 fail. - A deep-equality check confirms each new entry matches its source contract (all 8 true). ## Related - melodic-software/ci-workflows#669 (the rename) and the v0.34.0 release. - #672: switch naming-lint to enforcing. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
kyle-sexton
added a commit
that referenced
this pull request
Oct 4, 2026
…s to their convention names (#675) No related issue: convention-driven path rename tracked by the org rename map. ## Summary Moves `.github/actions/comment-hygiene` to `check-comment-markers` and `.github/actions/machine-specific-paths` to `check-machine-paths`, per standards `rename-map.json`. ## Fix `git mv` of both directories; path references updated in `pr-run-checks.yml`, `pr-require-checks.yml`, `README.md` and `ci-fanout-consolidation.test.cjs`. Workflow_call input names, composite `name:` values and script file names are unchanged (as in #669). ## Verification - Fan-out consolidation tests: 12 pass; scan-tree, superset and machine-path test scripts exit 0. - actionlint: only the pre-existing `$/` placeholder findings. - naming-lint (enforcing): 0 blocking, 1 unrelated warning (`plan` job id in maintenance-sync-standards.yml). ## Related - melodic-software/standards#679 (moves the sync destinations) - #669 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No related issue: Phase 4 of the GitHub Actions conventions program (tracking: melodic-software/standards#672)
Summary
Renames this repository's workflows and actions to the org naming convention (
<stage>-<function>[-<modifier>],name:= file stem), as recorded in standardscomponents/github-actions-conventions/rename-map.json. It also folds the three-selfdogfood callers into thin jobs inpr-require-checks.yml(formerlyci.yml). This is the content of the v0.34.0 restructure release; consumers keep working on their SHA pins until they repin.Fix
d1b5dc0:git mvof 45 files to their mapped paths,job_renamesapplied (includingneeds:andneeds.<id>.result), and reusables reference their own actions with$/.github/actions/<x>instead of a pinned full path.a724617: deletesclaude-review-self.yml,claude-security-review-self.ymlandissue-triage-label-self.yml; adds jobspr-review,pr-review-securityandintake-label-needs-triage, each pinned to the v0.33.0 SHA of its old path with the same permissions and the one secret the-selffile passed. It adds theready_for_reviewandissues: [opened, reopened]triggers and the event guards, keeps the three folded jobs out ofci-status, and deletescomposites-head, because$/from a./call already runs HEAD's composites.6c7ba42: the two standards-synced composites (comment-hygieneandmachine-specific-paths) are reached through$/. Their directories keep their old names until the standards sync destinations move.b2f99f9: the folded review jobs run only on opened, synchronize, reopened and ready_for_review, which is what the-selffiles ran on.ci-statuskeeps its job id and stays the only required check.Verification
planinmaintenance-sync-standards.yml). It is non-blocking, and the job id is unchanged from main.actionlint: only the$/ ... ref is missingerrors, which standards#675 waives through the synced config.node --test .github/scripts/*.test.cjs: 192/192 pass.Related
$/), feat(workflows): add pr-automerge-dependabot reusable #676 (lockstep drift), chore: sync standards components #677 (repin path mapping), fix(pulumi-guard): expect the release-deploy workflow name #678 (runner-policy$/), and the Dependabot ignores in six repos.🤖 Generated with Claude Code