Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/scripts/checks-outcome.test.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ test("the join reads every continue-on-error step", () => {
markdown: "markdownlint",
"exec-bit": "check-exec-bit",
"eol-renormalize": "check-line-endings",
"machine-specific-paths": "check-machine-paths",
"comment-hygiene": "check-comment-markers",
};
for (const step of composites) {
const name = step.id.replaceAll("_", "-");
Expand Down
2 changes: 1 addition & 1 deletion .github/scripts/ci-fanout-consolidation.test.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ test("pr-require-checks.yml consolidates the hygiene composites into the checks
// a repo-local script), so it must still run somewhere in this workflow.
assert.match(
ciWorkflow,
/^ {8}run: bash \.github\/actions\/comment-hygiene\/superset-test\.sh$/mu,
/^ {8}run: bash \.github\/actions\/check-comment-markers\/superset-test\.sh$/mu,
);
});

Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/pr-require-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,8 @@ jobs:
check-jsonschema-builtin-schema: vendor.dependabot
# Each scan skips its own action's source, whose pattern script and
# marker policy contain the literal bodies it matches.
machine-specific-paths-exclude: ':(exclude).github/actions/machine-specific-paths/**'
comment-hygiene-exclude: ':(exclude).github/actions/comment-hygiene/**'
machine-specific-paths-exclude: ':(exclude).github/actions/check-machine-paths/**'
comment-hygiene-exclude: ':(exclude).github/actions/check-comment-markers/**'
# Composites without a group here run ungated.
filters: |
markdown:
Expand Down Expand Up @@ -446,13 +446,13 @@ jobs:
- name: Verify the comment-hygiene prefilter is a superset of the policy library
# The git-grep prefilter must admit every line the policy flags, or the
# gate fails open. The checks reusable cannot run a repo-local script.
run: bash .github/actions/comment-hygiene/superset-test.sh
run: bash .github/actions/check-comment-markers/superset-test.sh
- name: Test machine-specific path span filtering
# Repo-local driver contract. The checks reusable cannot run this
# script, same as the comment-hygiene superset test above.
run: bash .github/actions/machine-specific-paths/check-machine-specific-paths.test.sh
run: bash .github/actions/check-machine-paths/check-machine-specific-paths.test.sh
- name: Test comment-hygiene scan-tree collection contracts
run: bash .github/actions/comment-hygiene/scan-tree.test.sh
run: bash .github/actions/check-comment-markers/scan-tree.test.sh
- name: Test the pull-request contract runner
run: bash .github/actions/pr-require-checks/check-contract/run.test.sh
- name: Test the ci-status aggregation and carry-forward runner
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pr-run-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ jobs:
id: machine_specific_paths
if: ${{ inputs.machine-specific-paths && fromJSON(steps.detect.outputs.results || '{}')['machine-specific-paths'] != 'false' }}
continue-on-error: true
uses: $/.github/actions/machine-specific-paths
uses: $/.github/actions/check-machine-paths
Comment thread
kyle-sexton marked this conversation as resolved.
with:
exclude: ${{ inputs.machine-specific-paths-exclude }}

Expand All @@ -281,7 +281,7 @@ jobs:
id: comment_hygiene
if: ${{ inputs.comment-hygiene && fromJSON(steps.detect.outputs.results || '{}')['comment-hygiene'] != 'false' }}
continue-on-error: true
uses: $/.github/actions/comment-hygiene
uses: $/.github/actions/check-comment-markers
with:
exclude: ${{ inputs.comment-hygiene-exclude }}

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -467,9 +467,9 @@ consumer to audit it.
- `.github/actions/check-action-filename` — rejects any tracked
`action.yaml` (GitHub also accepts this spelling, but every lane here globs
`action.yml` only); repo-wide, not scoped to `.github/actions/`.
- `.github/actions/machine-specific-paths` — rejects machine-specific absolute /
- `.github/actions/check-machine-paths` — rejects machine-specific absolute /
user-home paths in tracked files (portable placeholders allowed).
- `.github/actions/comment-hygiene` — scans comments for deferred-work markers
- `.github/actions/check-comment-markers` — scans comments for deferred-work markers
(TODO/FIXME/HACK/XXX) and tracker references against its bundled organization
policy, with an optional complete caller replacement.

Expand Down
Loading