Repository navigation
Drop the model chip from sidebar session rows - #1248
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Code Review by Qodo
1. Merge subject lacks the required issue reference
|
PR Summary by QodoRemove the model chip from sidebar session rows
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3cdbff3fce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Foreground="{StaticResource KcapInfoBrush}" | ||
| TextTrimming="CharacterEllipsis" /> | ||
| </Border> | ||
| <Border Classes="railChip" IsVisible="{Binding MachineBadge, Converter={x:Static ObjectConverters.IsNotNull}}" |
There was a problem hiding this comment.
Preserve model details for vendorless remote rows
When a remote AgentInstanceDto supplies Model but omits its nullable Vendor, AgentRow.FromRemote preserves the model while converting the vendor to an empty string, making HasModel true and HasVendor false. Removing this chip leaves the model only inside the now-hidden vendorMark tooltip, so the known model disappears completely for that valid wire shape; retain a model fallback when no vendor mark is rendered.
Useful? React with 👍 / 👎.
| TextTrimming="CharacterEllipsis" | ||
| ToolTip.Tip="{Binding Primary}" /> | ||
| <!-- The age sits on the right. Vendor, status and chips stay on the left | ||
| <!-- The age sits on the right. Vendor, status and machine stay on the left |
There was a problem hiding this comment.
Expose the model from the keyboard-focusable row
For users navigating the rail by keyboard, focus lands on the outer session Button, not the nested non-focusable vendor Border, so the only remaining model tooltip cannot be opened without pointer hover; its automation name also contains only the vendor. The updated test masks this by calling ToolTip.SetIsOpen programmatically. Attach the model help text to the focusable row or include it in the row's accessible name so removing the visible chip does not make the model inaccessible.
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Closes #1247 — AI-3377
What & why
Sidebar session rows showed a model chip beside the vendor mark and status. It crowded the 330px rail and wrapped the chips line; the vendor mark's tooltip already names the model, so only the chip goes.
Verification
dotnet run --project test/Capacitor.App.Tests.Unit: 2811 total, 1 failed —AttachmentTrayTests.Size_label_and_image_flag, which expects "2.3 MB" and gets "2,3 MB" under a comma-decimal locale; that class passes 7/7 withLC_ALL=en_US.UTF-8. The rail smoke test now asserts no visible row text carries the model while the tip still does.🤖 Generated with Claude Code