Skip to content

Drop the model chip from sidebar session rows - #1248

Merged
alexeyzimarev merged 2 commits into
mainfrom
desktop-rail-drop-model-chip
Sep 30, 2026
Merged

alexeyzimarev merged 2 commits into
mainfrom
desktop-rail-drop-model-chip

Conversation

@alexeyzimarev

Copy link
Copy Markdown
Member

Closes #1247 — AI-3377

What & why

Sidebar session rows showed a model chip beside the vendor mark and status. It crowded the 330px rail and wrapped the chips line; the vendor mark's tooltip already names the model, so only the chip goes.

Verification

dotnet run --project test/Capacitor.App.Tests.Unit: 2811 total, 1 failed — AttachmentTrayTests.Size_label_and_image_flag, which expects "2.3 MB" and gets "2,3 MB" under a comma-decimal locale; that class passes 7/7 with LC_ALL=en_US.UTF-8. The rail smoke test now asserts no visible row text carries the model while the tip still does.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@qodo-code-review

qodo-code-review Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (1) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Informational

1. Merge subject lacks the required issue reference 📘 Rule violation ⚙ Maintainability
Description
The pull request subject is Drop the model chip from sidebar session rows and does not end with a
single GitHub reference in the required (#digits) form. This prevents the subject from satisfying
the repository's enforced commit-format check even though the wording is otherwise a single
imperative clause.
Code

test/Capacitor.App.Tests.Unit/MainWindowSmokeTests.cs[716]

+    public async Task Vendor_mark_and_running_time_share_the_status_line() {
Relevance

● Weak

The actual commit subject already ends with the required (#1247) reference; the finding checks the
PR title instead.

PR-#659

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The commit subject supplied for this pull request is `Drop the model chip from sidebar session
rows, which has no trailing (#<digits>)` reference required by the checklist item.

Rule 2897961: Enforce single-clause imperative commit subject with GitHub issue reference and 80-char limit
test/Capacitor.App.Tests.Unit/MainWindowSmokeTests.cs[716-716]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The PR title does not end with a GitHub issue reference in the required `(#digits)` format.

## Fix Focus Areas
- test/Capacitor.App.Tests.Unit/MainWindowSmokeTests.cs[716-716]

## Recommended Fix
Change the pull request title to a single imperative clause followed by exactly one space and a GitHub issue reference, for example `Drop the model chip from sidebar session rows (#1247)`, keeping the total subject length at or below 80 characters.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗


Grey Divider

Context sources
✅ Compliance rules (platform): 64 rules
✅ Cross-repo context — repo relationships
Review mode: 🚀 Fast: This is a small, localized UI presentation change removing one sidebar chip, with a focused smoke-test update and no security, API, data, or broad behavioral risk.

Grey Divider

Tip of the day
💡 Did you know, you can route each severity your way: inline, summary, both, or drop

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Remove the model chip from sidebar session rows

🐞 Bug fix 🧪 Tests 🕐 10-20 Minutes

Grey Divider

AI Description

• Remove the model chip to reduce crowding and wrapping in the 330px session rail.
• Keep the model name in the vendor mark tooltip.
• Update the rail smoke test to verify the model is absent from visible row text.
Diagram

graph TD
  VM["Session data"] --> Row["Rail row"] --> Vendor["Vendor mark"] --> Tip["Model tooltip"]
  Row --> Status["Status mark"]
  Row --> Machine["Machine badge"]
  Row --> Age["Session age"]
Loading
High-Level Assessment

Removing only the redundant chip is the simplest approach: it frees row space while preserving model discovery in the existing vendor tooltip. Changing the view model or moving model information elsewhere would add scope without addressing a further need.

Files changed (2) +5 / -18

Bug fix (1) +1 / -8
SessionRailView.axamlRemove the model chip from session rows +1/-8

Remove the model chip from session rows

• Removes the model chip from the row's wrapping metadata area and updates its layout comment. The vendor mark tooltip continues to show the model name.

src/Capacitor.App/Views/SessionRailView.axaml

Tests (1) +4 / -10
MainWindowSmokeTests.csVerify model visibility and tooltip behavior +4/-10

Verify model visibility and tooltip behavior

• Replaces chip-specific layout assertions with a check that visible row text does not contain the model. Retains assertions for the vendor tooltip and alignment of the remaining row elements.

test/Capacitor.App.Tests.Unit/MainWindowSmokeTests.cs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3cdbff3fce

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Foreground="{StaticResource KcapInfoBrush}"
TextTrimming="CharacterEllipsis" />
</Border>
<Border Classes="railChip" IsVisible="{Binding MachineBadge, Converter={x:Static ObjectConverters.IsNotNull}}"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve model details for vendorless remote rows

When a remote AgentInstanceDto supplies Model but omits its nullable Vendor, AgentRow.FromRemote preserves the model while converting the vendor to an empty string, making HasModel true and HasVendor false. Removing this chip leaves the model only inside the now-hidden vendorMark tooltip, so the known model disappears completely for that valid wire shape; retain a model fallback when no vendor mark is rendered.

Useful? React with 👍 / 👎.

TextTrimming="CharacterEllipsis"
ToolTip.Tip="{Binding Primary}" />
<!-- The age sits on the right. Vendor, status and chips stay on the left
<!-- The age sits on the right. Vendor, status and machine stay on the left

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Expose the model from the keyboard-focusable row

For users navigating the rail by keyboard, focus lands on the outer session Button, not the nested non-focusable vendor Border, so the only remaining model tooltip cannot be opened without pointer hover; its automation name also contains only the vendor. The updated test masks this by calling ToolTip.SetIsOpen programmatically. Attach the model help text to the focusable row or include it in the row's accessible name so removing the visible chip does not make the model inaccessible.

Useful? React with 👍 / 👎.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-30T14:25:45.456223Z 3cdbff3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@alexeyzimarev
alexeyzimarev merged commit 69e1fc1 into main Sep 30, 2026
8 checks passed
@alexeyzimarev
alexeyzimarev deleted the desktop-rail-drop-model-chip branch September 30, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop the model chip from desktop sidebar session rows

1 participant