Implement dedicated kernels for {min,max}imum#592
Merged
Conversation
inducer
changed the title
{min,max}imum
inducer
force-pushed
the
minmaximum-kernel
branch
from
6c7027b to
97db7dd
Compare
Contributor
Yes, this PR does fix the NaNs we are seeing. |
inducer
force-pushed
the
minmaximum-kernel
branch
from
97db7dd to
e8c0d02
Compare
Owner
Author
|
Force-merging since earlier tests passed and the latest changes only affected the (project-local) tests, which have passed. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@majosm Turns out #584 mishandled infinities, which are used frequently as neutral elements.
@matthiasdiener This may be behind the NaNs that we were seeing, i.e. unrelated to the memory pool.