Fix nan handling in min/max/minimum/maximum#584
Merged
Conversation
inducer
force-pushed
the
fix-reduction-nan-handling
branch
from
7834344 to
ada2399
Compare
Owner
|
Thanks for putting this together! This is a bit hokey, but it ought to do the trick. Take a look, and if this looks good to you, then we can go ahead and merge this. |
inducer
force-pushed
the
fix-reduction-nan-handling
branch
from
ada2399 to
5b6e124
Compare
Owner
|
OK, next attempt. :) |
majosm
commented
Jul 25, 2022
majosm
left a comment
majosm
left a comment
Contributor
Author
There was a problem hiding this comment.
Looks good to me. 🙂
Owner
|
Thanks! In it goes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #583.
To-do: