Rework _get_common_dtype to tolerate unsized scalars, match numpy, warn about downcasts#604
Merged
Merged
Conversation
matthiasdiener
changed the title
matthiasdiener
changed the title
inducer
reviewed
Sep 9, 2022
inducer
changed the title
_get_common_dtype to tolerate unsized scalars, match numpy, warn about downcasts
Owner
|
I've reworked this a bit, and I'm inclined to merge it soon (tonight-ish) and release, assuming it passes CI. If you're around, I'd like it if you could give it a look. |
…rn about downcasts Co-authored-by: Matthias Diener <mdiener@illinois.edu>
Owner
Contributor
Author
|
I did a quick test of the reworked version, and it appears to fix illinois-ceesd/mirgecom#747. |
alexfikl
reviewed
Sep 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, (e.g.)
cla.minimum(scalar, array)won't work since scalar doesn't have a dtype attribute.Fixes mirgecom execution with limiter.
Related to #592. This is a regression from 2022.1.6. The attached tests fail on current main.