refactor: make_empty_graph() is now fully auto-generated

[szhorvat]

Related to #1140

make_empty_graph() is now fully auto-generated. The custom implementation is no longer needed after #1051.

This PR conflicts with the first commit from the draft PR #1044.

[aviator-app]

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

---

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

[krlmlr]

Why is this urgent?

[szhorvat]

If you don't want to merge it now your can put it on hold. This was part of verifying that scalar conversion checks are working as intended and there are no crashes

[szhorvat]

I should mention that this also catches errors that the previous version did not (passing a longer vector where a scalar is expected). I don't see any disadvantage to merging this, quite the contrary.

[szhorvat]

Is there any reason to delay merging this? Instead of saying it conflicts with the first commit in #1044, I should have said that it replaces that commit. This is not a breaking change, just simplifies codes and uses standard error reporting instead of a custom version.

[krlmlr]

We can merge right after the 2.0.0 release, hopefully next week, unless the revdepchecks show anything major.

[krlmlr]

Do we never intend to expose or even use make_empty_attrs() ? Should we add a comment to explain the reasoning, like you did for other low-level functions earlier?

I still need to run revdepchecks on this.

[szhorvat]

Do we never intend to expose or even use make_empty_attrs() ?

No

Should we add a comment to explain the reasoning, like you did for other low-level functions earlier?

Done

I still need to run revdepchecks on this.

Risk of breakage is very low, but always a good practice to run revdepchecks

[krlmlr]

Thanks!