Merged
Conversation
Contributor
Current Aviator status
This PR was merged using Aviator.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
krlmlr
force-pushed
the
f-stimulus-autogen
branch
from
7e92df8 to
ad0af06
Compare
Contributor
Author
|
For this PR, #1048 was necessary as a prerequisite. I suspect we'll need a few more changes like this. |
krlmlr
force-pushed
the
f-stimulus-autogen
branch
from
ad0af06 to
33fe244
Compare
Member
krlmlr
force-pushed
the
f-stimulus-autogen
branch
2 times, most recently
from
d6a1db6 to
e4427ce
Compare
Closed
Contributor
|
This pull request can't be queued because it's currently a draft. |
aviator-app
bot
force-pushed
the
f-stimulus-autogen
branch
from
e4427ce to
f87a91c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@maelle @Antonov548: All but the last three commits are part of #1043, they will be gone from this PR soon.
The last three commits show the work that, I think, should be done to make this project more sustainable. The
IGNOREbits in the YAML turn off autogeneration of bindings. In theadd_edgesexample, I had to rename the function (beforehand, in a separate commit!) to keep the package buildable. In yet another follow-up step (not shown here), we can check if the autogenerated code serves the same purpose, and remove the manual code.The
src/cpp11.cppfile is generated ondevtools::load_all(). It depends on which C functions are used from the R side. Expect surprises.Can you please take this on, for all functions that are currently ignored? Happy to assist.