fix: add scalar conversion checks in a few critical places#1069
Merged
aviator-app[bot] merged 1 commit intomainfrom Jan 2, 2024
Merged
fix: add scalar conversion checks in a few critical places#1069aviator-app[bot] merged 1 commit intomainfrom
aviator-app[bot] merged 1 commit intomainfrom
Conversation
Contributor
Current Aviator status
This PR was merged using Aviator. See the real-time status of this PR on the Aviator webapp. Use the Aviator Chrome Extension to see the status of your PR within GitHub.
|
Member
Author
Antonov548
approved these changes
Jan 2, 2024
Contributor
|
Thanks! |
in manually written code
aviator-app
bot
force-pushed
the
fix/scalar-conversion-checks-in-manual-code
branch
from
6bf98a8 to
bf3a283
Compare
aviator-app
bot
deleted the
fix/scalar-conversion-checks-in-manual-code
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds checks for converting scalars (especially scalar integers) to C in a few heavily used and critical places. This is similar to #1051 but for manually written code. I will not add the checks for all manually written code, only for the most important parts. The rest should be handled by moving functions to auto-generation.
I needed to change a test which verified that
make_graph(NULL, n = NULL)worked. IMO usingn=NULLshould not be allowed an in fact this probably triggered an invalid memory access, as the code would index into a zero-length vector (which is somehow not caught by the sanitizer). I am not sure why this test was present.Because of the presence of this unusual test, running revdepchecks would be a good idea.