[henrychu04]

Stage 2 of the eb1510d → be1d066 upstream sync: upstream's forge-definitions refactor (pingdotgg#23992–pingdotgg#24288) and the 11 commits after it. Stage 1 was #253.

What changed

Upstream moved per-host behaviour into each forge's shared definition and server driver, read through one registry in the new @t3tools/source-control-definitions package. T3 Coder carries that package with only GitLab's definition, so most fork GitLab shims are now expressed by upstream's hooks and are gone:

• Host terminology ("MR", "merge request") comes from GitLab's definition on most surfaces (fix(clients): change requests use their host's own term pingdotgg/t3code#23999); !N is still applied by hand.
• GitManager reads merge request heads from GitLab's changeRequestHeadRef; upstream's targetsOnlyRemote is carried.
• VcsProcess's semaphore and glab failure classification come from the per-call concurrency/classifyFailure hooks.
• Icons, clone/publish pickers, settings search and project matching read the definitions; client-runtime's sourceControlClients.ts is upstream's.

GitLab seams moved into the new layout (marked Coder:):

• GitLab definition: merge request URLs on any host, author profile links, and new referenceAutolinks (!N, #N, commit SHAs under /-/), so upstream's host-neutral web autolinker is carried unchanged.
• The registry's parseChangeRequestUrl rejects URLs carrying credentials (replaces the deleted shared/changeRequestUrl.ts seam).
• The GitLab-or-unknown project filter moved to client-runtime changeRequestLinks.ts.
• ChatMarkdown opens GitLab references directly (no GitHub-style confirmation).

Still cut: GitHub/Forgejo/Bitbucket/Azure DevOps/GitCafe packages and definitions, cross-environment pull request routing and its settings, host token/account/host-settings forms, credentialed host media (SOURCE_CONTROL_MEDIA_ASSET), mobile/desktop/relay/Cursor.

Found and fixed

• An earlier sync (ed3f965) had dropped RepositoryIdentityResolver's refine option and the helper never wired upstream's refine step. Upstream now relies on it (GitLab confirms a self-hosted host whose hostname lacks "gitlab" through glab auth status) after deleting PullRequestService's unknown-kind refinement. Restored and wired into coderServer.ts.

Behaviour change to note

• A pasted owner/repo clone shorthand now becomes git@gitlab.com:owner/repo.git (upstream takes the first registered host's default transport; before, it produced GitHub over HTTPS).

Verification

• pnpm test:coder: every package passes. The one failure under full load is web localApi.test.ts's afterEach hook timeout, a known flake listed in Tests that flake under full-suite load #236; it passes alone and the unit project passes alone (244 files).
• All AGENTS.md typechecks (+ source-control-definitions), pnpm knip:check, unused-locals check, pnpm build, vp fmt --check over changed files
• sync.md section 6: marker drops all match seams replaced by upstream hooks; lost upstream lines are cut hosts, routing, credential settings, host media, or wording seams; no RPC, capability, listener, MCP, Claude query, or Node changes in the range
• Live smoke (gateway + real helper, no browser): stage smoke OK, signed asset/upload smoke OK (26 checks), and the fake-glab merge request smoke on a self-hosted host: list, summary, detail, diff, checks, author filter options all succeed

🤖 Generated with Claude Code