[henrychu04]

Follow-ups from the Fable review of #253 and #254. All of these predate those PRs.

• GitLab uploads resolve below the project. A description's /uploads/<secret>/<file> was resolved against the host root (https://host/uploads/…). GitLab serves it under the project (https://host/group/project/uploads/…), so attachments in merge request descriptions linked to the wrong place. splitPullRequestBody now joins the path onto the repository URL. The test-only hostUrl prop on PullRequestMarkdown is gone, and both tests now expect the project URL.
• GitLab uploads inside Markdown resolve too. GitLab writes a pasted screenshot as ![image](/uploads/…) and other files as [name](/uploads/…). Those kept a relative address, so they showed as broken images or links. PullRequestMarkdown's new remarkGitLabUploads plugin joins image, link, and reference-definition URLs onto the project with the same resolveGitLabUploadUrl. It works on the parsed tree, so code blocks are untouched.
• The link dialog accepts !42. "Copy MR number" copies !42, which the dialog rejected. pullRequestLinkInput.ts now takes #, !, or a bare number, and the placeholder and validation text say !42.
• Upstream's snapshot-status fallback. ThreadStatusIndicators.tsx uses upstream's two lines again. They read GitLab for every link the registry accepts.
• coder-only.md drift:
  • Dropped the allowStale note, which describes upstream behavior.
  • Documented the hover-preview read and why gitLabMergeRequestBrowserUrl stays.
  • Noted that an unknown provider gets upstream's generic wording.

Verification

• pnpm typecheck:web, client-runtime typecheck, vp fmt --check, and pnpm test:knip pass.
• pnpm test:client-runtime passes (751 tests).
• pnpm test:web:coder passes (277 files, 3420 tests).
• pnpm build passes.
• A scratch render of a merge request body checked the upload forms: inline images, links, standalone images, .mp4 videos, and reference-style definitions all became https://gitlab.example/group/project/uploads/…. A fenced code block kept its raw text, and external images were unchanged. It was deleted afterwards.
• A scratch test checked that !42, #42, and 42 parse, that !!42 is rejected, and that !42 resolves to the project's merge request URL. It was deleted afterwards.

Not checked live: how an upload renders against a real GitLab instance. Images load straight from GitLab in the browser, so on a private project they need the browser's GitLab session, the same as other GitLab media on main.

🤖 Generated with Claude Code