fix(visionOS): Remove Interoperability mode for visionOS#6077
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6077 +/- ##
=============================================
- Coverage 86.602% 86.592% -0.011%
=============================================
Files 432 433 +1
Lines 36956 36941 -15
Branches 17426 17416 -10
=============================================
- Hits 32005 31988 -17
Misses 4907 4907
- Partials 44 46 +2
... and 17 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ef2c9b3 | 1222.12 ms | 1253.96 ms | 31.84 ms |
| c8dd5e4 | 1217.67 ms | 1242.90 ms | 25.23 ms |
| ab0ba7e | 1216.08 ms | 1242.40 ms | 26.31 ms |
| 354b020 | 1223.88 ms | 1236.82 ms | 12.94 ms |
| 25f2d2c | 1232.02 ms | 1242.78 ms | 10.76 ms |
| e446901 | 1233.32 ms | 1252.32 ms | 19.00 ms |
| 27e7514 | 1229.47 ms | 1245.60 ms | 16.13 ms |
| 7273bf4 | 1202.42 ms | 1227.62 ms | 25.21 ms |
| c03a8d8 | 1234.77 ms | 1259.19 ms | 24.42 ms |
| 6cb4338 | 1238.47 ms | 1256.96 ms | 18.49 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ef2c9b3 | 23.75 KiB | 933.03 KiB | 909.29 KiB |
| c8dd5e4 | 23.75 KiB | 913.48 KiB | 889.72 KiB |
| ab0ba7e | 23.75 KiB | 904.54 KiB | 880.79 KiB |
| 354b020 | 23.75 KiB | 878.19 KiB | 854.44 KiB |
| 25f2d2c | 23.75 KiB | 866.69 KiB | 842.94 KiB |
| e446901 | 23.75 KiB | 933.33 KiB | 909.58 KiB |
| 27e7514 | 23.75 KiB | 919.69 KiB | 895.94 KiB |
| 7273bf4 | 23.75 KiB | 908.01 KiB | 884.26 KiB |
| c03a8d8 | 23.75 KiB | 928.15 KiB | 904.40 KiB |
| 6cb4338 | 23.75 KiB | 913.63 KiB | 889.88 KiB |
Previous results on branch: itay/remove_iterop_mode_xrOS
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f08c6d9 | 1217.92 ms | 1238.52 ms | 20.60 ms |
| 821c3ff | 1205.94 ms | 1245.33 ms | 39.39 ms |
| e677158 | 1230.94 ms | 1259.51 ms | 28.57 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f08c6d9 | 23.75 KiB | 947.54 KiB | 923.79 KiB |
| 821c3ff | 23.75 KiB | 959.44 KiB | 935.69 KiB |
| e677158 | 23.75 KiB | 946.69 KiB | 922.94 KiB |
…entry-cocoa into itay/remove_iterop_mode_xrOS
…move_iterop_mode_xrOS
|
@philipphofmann this was enabled on this commit: 4569cc9 I will remove |
Nope, sorry, I have no idea. I have little knowledge of the interoperability mode. If you've done your research and don't think we need it, I can only ask how can we ensure we don't break anything and how can we test this? Maybe a review from @noahsmartin would be useful cause his knowledge on such topics is way more extensive than mine. |
|
4569cc9 points to #4462 which closed #3809, where quite a lot of people were asking for this to be enabled. You should probably perform the same checks as done in this comment: |
|
Thanks @philprime, I was able to reproduce with those comments. I will add an integration test to ensure this is working |
|
Proof of the fix and a verification job to are working: https://github.com/getsentry/sentry-cocoa/actions/runs/17501347281/job/49715077730?pr=6092 |
📜 Description
Removes swift's interoperability mode set to C++.
💡 Motivation and Context
If we have swift interoperability mode, each target depending on Sentry will need to enable this which is annoying.
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.Closes #6103