fix: Build visionOS project with static Sentry SDK#4462
Merged
Conversation
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 51ffd8c | 1194.60 ms | 1215.70 ms | 21.10 ms |
| 0559a8f | 1236.90 ms | 1253.46 ms | 16.56 ms |
| 75f7fc8 | 1239.31 ms | 1266.12 ms | 26.82 ms |
| 5c115c5 | 1249.04 ms | 1260.36 ms | 11.32 ms |
| 6ae86f6 | 1231.90 ms | 1255.90 ms | 24.00 ms |
| 7419285 | 1209.53 ms | 1244.72 ms | 35.19 ms |
| 76c2ac7 | 1226.84 ms | 1247.22 ms | 20.39 ms |
| dc8ab43 | 1220.39 ms | 1238.04 ms | 17.65 ms |
| e758449 | 1243.41 ms | 1246.71 ms | 3.31 ms |
| 04c0c68 | 1223.22 ms | 1251.24 ms | 28.02 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 51ffd8c | 21.58 KiB | 418.70 KiB | 397.11 KiB |
| 0559a8f | 21.58 KiB | 419.81 KiB | 398.22 KiB |
| 75f7fc8 | 21.58 KiB | 704.23 KiB | 682.65 KiB |
| 5c115c5 | 22.85 KiB | 411.72 KiB | 388.87 KiB |
| 6ae86f6 | 21.58 KiB | 625.82 KiB | 604.23 KiB |
| 7419285 | 20.76 KiB | 432.99 KiB | 412.22 KiB |
| 76c2ac7 | 21.58 KiB | 695.48 KiB | 673.90 KiB |
| dc8ab43 | 21.58 KiB | 697.83 KiB | 676.25 KiB |
| e758449 | 22.85 KiB | 407.62 KiB | 384.77 KiB |
| 04c0c68 | 22.85 KiB | 414.09 KiB | 391.24 KiB |
philipphofmann
left a comment
Member
There was a problem hiding this comment.
Mostly questions to understand this change better.
philipphofmann
approved these changes
Oct 24, 2024
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
We need to enable Swift interoperability with c++ for our visionOS SDK, in order to make the static SDK work with visionOS projects
💡 Motivation and Context
Close #3809
💚 How did you test it?
External sample
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.