Skip to content

chore(ci): Remove Package@swift-5.9.swift#6110

Merged
itaybre merged 1 commit into
mainfrom
itay/remove_package@swift-5.9.swift
Sep 9, 2025
Merged

chore(ci): Remove Package@swift-5.9.swift#6110
itaybre merged 1 commit into
mainfrom
itay/remove_package@swift-5.9.swift

Conversation

@itaybre

@itaybre itaybre commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

📜 Description

Removes Package@swift-5.9.swift since it is not needed anymore.

💡 Motivation and Context

Package@swift-5.9.swift was added because we needed some configuration specific to visionOS.
Since that is not needed anymore (after #6077), we can remove it.

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

No user changes, so #skip-changelog

@github-actions

github-actions Bot commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • .github/file-filters.yml

@codecov

codecov Bot commented Sep 8, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.586%. Comparing base (f5666e7) to head (4e6d839).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6110       +/-   ##
=============================================
- Coverage   86.602%   86.586%   -0.017%     
=============================================
  Files          433       433               
  Lines        36941     36941               
  Branches     17417     17417               
=============================================
- Hits         31992     31986        -6     
- Misses        4906      4909        +3     
- Partials        43        46        +3     

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5666e7...4e6d839. Read the comment docs.

@itaybre itaybre marked this pull request as ready for review September 8, 2025 21:04
@itaybre itaybre enabled auto-merge (squash) September 8, 2025 21:08
@itaybre itaybre changed the title chore(ci): Remove Package.swift checks chore(ci): Remove Package@swift-5.9.swift Sep 8, 2025
@itaybre itaybre disabled auto-merge September 8, 2025 21:08
@itaybre itaybre enabled auto-merge (squash) September 8, 2025 21:08
@github-actions

github-actions Bot commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1222.06 ms 1250.20 ms 28.14 ms
Size 23.75 KiB 963.18 KiB 939.43 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
67e8e3e 1238.80 ms 1266.02 ms 27.22 ms
d3f650a 1225.45 ms 1241.86 ms 16.41 ms
0529194 1237.23 ms 1254.67 ms 17.44 ms
13bc1aa 1244.04 ms 1262.89 ms 18.85 ms
9450cb4 1221.29 ms 1232.96 ms 11.67 ms
4bf98bf 1219.13 ms 1244.50 ms 25.38 ms
db9572a 1200.27 ms 1234.80 ms 34.53 ms
2a6f451 1212.89 ms 1237.45 ms 24.56 ms
7f2f69c 1237.61 ms 1266.96 ms 29.35 ms
d38165b 1211.41 ms 1242.49 ms 31.08 ms

App size

Revision Plain With Sentry Diff
67e8e3e 23.75 KiB 919.88 KiB 896.13 KiB
d3f650a 23.75 KiB 902.48 KiB 878.73 KiB
0529194 23.74 KiB 891.02 KiB 867.28 KiB
13bc1aa 23.75 KiB 908.40 KiB 884.65 KiB
9450cb4 23.75 KiB 908.55 KiB 884.80 KiB
4bf98bf 23.75 KiB 919.70 KiB 895.95 KiB
db9572a 23.75 KiB 858.69 KiB 834.93 KiB
2a6f451 23.75 KiB 913.13 KiB 889.38 KiB
7f2f69c 23.75 KiB 913.38 KiB 889.63 KiB
d38165b 23.75 KiB 855.37 KiB 831.62 KiB

@itaybre itaybre disabled auto-merge September 9, 2025 13:08
@itaybre itaybre merged commit e36128b into main Sep 9, 2025
191 of 193 checks passed
@itaybre itaybre deleted the itay/remove_package@swift-5.9.swift branch September 9, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants