chore(ci): Remove Package@swift-5.9.swift#6110
Merged
Merged
Conversation
Contributor
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6110 +/- ##
=============================================
- Coverage 86.602% 86.586% -0.017%
=============================================
Files 433 433
Lines 36941 36941
Branches 17417 17417
=============================================
- Hits 31992 31986 -6
- Misses 4906 4909 +3
- Partials 43 46 +3 see 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
noahsmartin
approved these changes
Sep 8, 2025
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 67e8e3e | 1238.80 ms | 1266.02 ms | 27.22 ms |
| d3f650a | 1225.45 ms | 1241.86 ms | 16.41 ms |
| 0529194 | 1237.23 ms | 1254.67 ms | 17.44 ms |
| 13bc1aa | 1244.04 ms | 1262.89 ms | 18.85 ms |
| 9450cb4 | 1221.29 ms | 1232.96 ms | 11.67 ms |
| 4bf98bf | 1219.13 ms | 1244.50 ms | 25.38 ms |
| db9572a | 1200.27 ms | 1234.80 ms | 34.53 ms |
| 2a6f451 | 1212.89 ms | 1237.45 ms | 24.56 ms |
| 7f2f69c | 1237.61 ms | 1266.96 ms | 29.35 ms |
| d38165b | 1211.41 ms | 1242.49 ms | 31.08 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 67e8e3e | 23.75 KiB | 919.88 KiB | 896.13 KiB |
| d3f650a | 23.75 KiB | 902.48 KiB | 878.73 KiB |
| 0529194 | 23.74 KiB | 891.02 KiB | 867.28 KiB |
| 13bc1aa | 23.75 KiB | 908.40 KiB | 884.65 KiB |
| 9450cb4 | 23.75 KiB | 908.55 KiB | 884.80 KiB |
| 4bf98bf | 23.75 KiB | 919.70 KiB | 895.95 KiB |
| db9572a | 23.75 KiB | 858.69 KiB | 834.93 KiB |
| 2a6f451 | 23.75 KiB | 913.13 KiB | 889.38 KiB |
| 7f2f69c | 23.75 KiB | 913.38 KiB | 889.63 KiB |
| d38165b | 23.75 KiB | 855.37 KiB | 831.62 KiB |
philipphofmann
pushed a commit
that referenced
this pull request
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Removes
Package@swift-5.9.swiftsince it is not needed anymore.💡 Motivation and Context
Package@swift-5.9.swiftwas added because we needed some configuration specific to visionOS.Since that is not needed anymore (after #6077), we can remove it.
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.No user changes, so #skip-changelog