Skip to content

Add icon for Okta Advanced Server Access macOS FMA - #48956

Merged
allenhouchins merged 1 commit into
mainfrom
add-okta-asa-icon
Jul 8, 2026
Merged

Add icon for Okta Advanced Server Access macOS FMA#48956
allenhouchins merged 1 commit into
mainfrom
add-okta-asa-icon

Conversation

@allenhouchins

@allenhouchins allenhouchins commented Jul 8, 2026

Copy link
Copy Markdown
Member

The Okta Advanced Server Access macOS Fleet-maintained app had no icon — the Fleet UI fell back to the generic package icon, and the fleetdm.com software catalog used the fallback icon.

The icon was extracted from the vendor's ScaleFT.app bundle inside ScaleFT-1.108.0.pkg (downloaded from the URL in ee/maintained-apps/outputs/okta-advanced-server-access/darwin.json; SHA-256 verified against the manifest) and generated with tools/software/icons/generate-icons.sh:

  • frontend/pages/SoftwarePage/components/icons/ScaleFt.tsx: new icon component.
  • frontend/pages/SoftwarePage/components/icons/index.ts: two map entries — "okta advanced server access" (matches the FMA list name) and "scaleft" (matches host inventory, since the app's CFBundleName is ScaleFT and there is no CFBundleDisplayName).
  • website/assets/images/app-icon-okta-advanced-server-access-60x60@2x.png: 128×128 PNG for the fleetdm.com software catalog (filename follows the app-icon-<slug> convention used by build-static-content.js).

Checklist for submitter

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters.

Testing

  • QA'd all new/changed functionality manually

Summary by CodeRabbit

  • New Features
    • Added a new software icon for ScaleFT/Okta Advanced Server Access.
    • The icon now appears automatically when those software names are recognized in the app.

Copilot AI review requested due to automatic review settings July 8, 2026 16:03
@allenhouchins
allenhouchins requested a review from a team as a code owner July 8, 2026 16:03
@fleet-release
fleet-release requested a review from eashaw July 8, 2026 16:03
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 665f05c0-821a-4806-95c2-628791d28de5

📥 Commits

Reviewing files that changed from the base of the PR and between 496d4f5 and fa19236.

⛔ Files ignored due to path filters (1)
  • website/assets/images/app-icon-okta-advanced-server-access-60x60@2x.png is excluded by !**/*.png
📒 Files selected for processing (2)
  • frontend/pages/SoftwarePage/components/icons/ScaleFt.tsx
  • frontend/pages/SoftwarePage/components/icons/index.ts

Walkthrough

This change adds a new React SVG icon component, ScaleFt, which renders a base64-embedded PNG artwork within a 32x32 SVG element. It also registers this icon in the SOFTWARE_NAME_TO_ICON_MAP registry under two keys, "okta advanced server access" and "scaleft", enabling icon lookup for these software names via existing matching logic.

Possibly related PRs

  • fleetdm/fleet#47192: Both PRs add new SVG icon components and update the same icon registry to register them.
  • fleetdm/fleet#47648: Both PRs add a new SVG icon component and extend SOFTWARE_NAME_TO_ICON_MAP with new software name keys.
  • fleetdm/fleet#47396: Both PRs extend the same icon registry with new icon components for newly supported apps.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding an icon for Okta Advanced Server Access on macOS.
Description check ✅ Passed The description follows the template well and includes the change summary, implementation details, and testing notes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-okta-asa-icon

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a dedicated icon for the Okta Advanced Server Access macOS Fleet-maintained app so Fleet’s Software UI can display the correct app icon (instead of the generic package icon), by introducing a new icon component and wiring it into the software-name → icon mapping.

Changes:

  • Added a new ScaleFt icon React component (SVG embedding a base64 PNG).
  • Mapped "okta advanced server access" and "scaleft" software names to the new icon in the icon lookup map.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
frontend/pages/SoftwarePage/components/icons/ScaleFt.tsx Adds the new ScaleFt icon component used by the Software page icon system.
frontend/pages/SoftwarePage/components/icons/index.ts Registers the new icon and maps relevant software names to it for matching in the UI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 68.11%. Comparing base (cb09b42) to head (fa19236).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...nd/pages/SoftwarePage/components/icons/ScaleFt.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #48956    +/-   ##
========================================
  Coverage   68.11%   68.11%            
========================================
  Files        3709     3717     +8     
  Lines      235099   235121    +22     
  Branches    12352    12500   +148     
========================================
+ Hits       160129   160145    +16     
- Misses      60594    60600     +6     
  Partials    14376    14376            
Flag Coverage Δ
frontend 59.28% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@allenhouchins
allenhouchins merged commit 3607899 into main Jul 8, 2026
28 checks passed
@allenhouchins
allenhouchins deleted the add-okta-asa-icon branch July 8, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants