Add icon for Okta Advanced Server Access macOS FMA - #48956
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
WalkthroughThis change adds a new React SVG icon component, Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds a dedicated icon for the Okta Advanced Server Access macOS Fleet-maintained app so Fleet’s Software UI can display the correct app icon (instead of the generic package icon), by introducing a new icon component and wiring it into the software-name → icon mapping.
Changes:
- Added a new
ScaleFticon React component (SVG embedding a base64 PNG). - Mapped
"okta advanced server access"and"scaleft"software names to the new icon in the icon lookup map.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/pages/SoftwarePage/components/icons/ScaleFt.tsx | Adds the new ScaleFt icon component used by the Software page icon system. |
| frontend/pages/SoftwarePage/components/icons/index.ts | Registers the new icon and maps relevant software names to it for matching in the UI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #48956 +/- ##
========================================
Coverage 68.11% 68.11%
========================================
Files 3709 3717 +8
Lines 235099 235121 +22
Branches 12352 12500 +148
========================================
+ Hits 160129 160145 +16
- Misses 60594 60600 +6
Partials 14376 14376
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The Okta Advanced Server Access macOS Fleet-maintained app had no icon — the Fleet UI fell back to the generic package icon, and the fleetdm.com software catalog used the fallback icon.
The icon was extracted from the vendor's
ScaleFT.appbundle insideScaleFT-1.108.0.pkg(downloaded from the URL inee/maintained-apps/outputs/okta-advanced-server-access/darwin.json; SHA-256 verified against the manifest) and generated withtools/software/icons/generate-icons.sh:frontend/pages/SoftwarePage/components/icons/ScaleFt.tsx: new icon component.frontend/pages/SoftwarePage/components/icons/index.ts: two map entries —"okta advanced server access"(matches the FMA list name) and"scaleft"(matches host inventory, since the app'sCFBundleNameisScaleFTand there is noCFBundleDisplayName).website/assets/images/app-icon-okta-advanced-server-access-60x60@2x.png: 128×128 PNG for the fleetdm.com software catalog (filename follows theapp-icon-<slug>convention used bybuild-static-content.js).Checklist for submitter
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters.Testing
Summary by CodeRabbit