Add SmartSVN icon and update icons map - #47648
Conversation
Add a new Smartsvn SVG component (frontend/pages/SoftwarePage/components/icons/Smartsvn.tsx) and include the PNG asset (website/assets/images/app-icon-smartsvn-60x60@2x.png). Update the icons index to import AwsCli and Smartsvn, add mappings for "aws command line interface", "druva insync", "smartsvn", and "vnc server", and normalize Azul Zulu keys from "azul zulu 25 jdk/jre" to "azul zulu jdk/jre".
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #47648 +/- ##
==========================================
- Coverage 67.19% 67.19% -0.01%
==========================================
Files 3616 3618 +2
Lines 229106 229110 +4
Branches 11900 11900
==========================================
+ Hits 153942 153944 +2
- Misses 61322 61324 +2
Partials 13842 13842
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
WalkthroughA new React/TypeScript SVG icon component Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds SmartSVN icon support to Fleet’s Software page icon system by introducing a new icon component and extending the fuzzy software-name-to-icon mapping (including additional aliases and a key normalization for Azul Zulu).
Changes:
- Added a new
Smartsvnicon component. - Updated the icons index to import/register
AwsCliandSmartsvnand add new name aliases for icon matching. - Normalized Azul Zulu icon keys to match the expected “Azul Zulu JDK/JRE …” name prefix format used by loose-prefix matching.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/pages/SoftwarePage/components/icons/Smartsvn.tsx | Adds the SmartSVN icon component as a 32x32 SVG wrapper around a base64 PNG. |
| frontend/pages/SoftwarePage/components/icons/index.ts | Registers the new icons and expands/normalizes SOFTWARE_NAME_TO_ICON_MAP entries for fuzzy prefix matching. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add a new Smartsvn SVG component (frontend/pages/SoftwarePage/components/icons/Smartsvn.tsx) and include the PNG asset (website/assets/images/app-icon-smartsvn-60x60@2x.png). Update the icons index to import AwsCli and Smartsvn, add mappings for "aws command line interface", "druva insync", "smartsvn", and "vnc server", and normalize Azul Zulu keys from "azul zulu 25 jdk/jre" to "azul zulu jdk/jre".
Summary by CodeRabbit