Skip to content

Add SmartSVN icon and update icons map - #47648

Merged
allenhouchins merged 1 commit into
mainfrom
allenhouchins-fix-icons
Jun 16, 2026
Merged

Add SmartSVN icon and update icons map#47648
allenhouchins merged 1 commit into
mainfrom
allenhouchins-fix-icons

Conversation

@allenhouchins

@allenhouchins allenhouchins commented Jun 16, 2026

Copy link
Copy Markdown
Member

Add a new Smartsvn SVG component (frontend/pages/SoftwarePage/components/icons/Smartsvn.tsx) and include the PNG asset (website/assets/images/app-icon-smartsvn-60x60@2x.png). Update the icons index to import AwsCli and Smartsvn, add mappings for "aws command line interface", "druva insync", "smartsvn", and "vnc server", and normalize Azul Zulu keys from "azul zulu 25 jdk/jre" to "azul zulu jdk/jre".

Summary by CodeRabbit

  • New Features
    • Added SmartSVN icon component to the application.
    • Extended software icon support to recognize additional tools including AWS Command Line Interface, VNC Server, Druva Insync, and SmartSVN.
    • Updated Azul Zulu icon mappings for improved software recognition.

Add a new Smartsvn SVG component (frontend/pages/SoftwarePage/components/icons/Smartsvn.tsx) and include the PNG asset (website/assets/images/app-icon-smartsvn-60x60@2x.png). Update the icons index to import AwsCli and Smartsvn, add mappings for "aws command line interface", "druva insync", "smartsvn", and "vnc server", and normalize Azul Zulu keys from "azul zulu 25 jdk/jre" to "azul zulu jdk/jre".
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 67.19%. Comparing base (464d741) to head (ddf6a8c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...d/pages/SoftwarePage/components/icons/Smartsvn.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #47648      +/-   ##
==========================================
- Coverage   67.19%   67.19%   -0.01%     
==========================================
  Files        3616     3618       +2     
  Lines      229106   229110       +4     
  Branches    11900    11900              
==========================================
+ Hits       153942   153944       +2     
- Misses      61322    61324       +2     
  Partials    13842    13842              
Flag Coverage Δ
frontend 57.99% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@allenhouchins
allenhouchins marked this pull request as ready for review June 16, 2026 03:42
@allenhouchins
allenhouchins requested a review from a team as a code owner June 16, 2026 03:42
Copilot AI review requested due to automatic review settings June 16, 2026 03:42
@fleet-release
fleet-release requested a review from eashaw June 16, 2026 03:42
@allenhouchins
allenhouchins merged commit a928a65 into main Jun 16, 2026
26 of 28 checks passed
@allenhouchins
allenhouchins deleted the allenhouchins-fix-icons branch June 16, 2026 03:43
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f2586701-07b3-467c-893d-888f81733590

📥 Commits

Reviewing files that changed from the base of the PR and between 464d741 and ddf6a8c.

⛔ Files ignored due to path filters (1)
  • website/assets/images/app-icon-smartsvn-60x60@2x.png is excluded by !**/*.png
📒 Files selected for processing (2)
  • frontend/pages/SoftwarePage/components/icons/Smartsvn.tsx
  • frontend/pages/SoftwarePage/components/icons/index.ts

Walkthrough

A new React/TypeScript SVG icon component Smartsvn is added, rendering a 32x32 SVG with an embedded base64 PNG and forwarding standard SVG props. The icon index file imports Smartsvn and AwsCli, then extends SOFTWARE_NAME_TO_ICON_MAP with entries for "aws command line interface", "druva insync", "smartsvn", and "vnc server". The existing Azul Zulu key matching is also corrected from "azul zulu 25 jdk/jre" to "azul zulu jdk/jre".

Possibly related PRs

  • fleetdm/fleet#46381: Previously added Azul Zulu 25 JDK/JRE and RealVNC entries to SOFTWARE_NAME_TO_ICON_MAP; this PR adjusts the Azul Zulu key and adds a VNC Server mapping at the same code location.
  • fleetdm/fleet#47396: Extends SOFTWARE_NAME_TO_ICON_MAP with new app-name keys and icon imports in the same index.ts file.
  • fleetdm/fleet#47192: Adds new SVG icon components under the same icons directory and registers them in SOFTWARE_NAME_TO_ICON_MAP.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch allenhouchins-fix-icons

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds SmartSVN icon support to Fleet’s Software page icon system by introducing a new icon component and extending the fuzzy software-name-to-icon mapping (including additional aliases and a key normalization for Azul Zulu).

Changes:

  • Added a new Smartsvn icon component.
  • Updated the icons index to import/register AwsCli and Smartsvn and add new name aliases for icon matching.
  • Normalized Azul Zulu icon keys to match the expected “Azul Zulu JDK/JRE …” name prefix format used by loose-prefix matching.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
frontend/pages/SoftwarePage/components/icons/Smartsvn.tsx Adds the SmartSVN icon component as a 32x32 SVG wrapper around a base64 PNG.
frontend/pages/SoftwarePage/components/icons/index.ts Registers the new icons and expands/normalizes SOFTWARE_NAME_TO_ICON_MAP entries for fuzzy prefix matching.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants