Add SSMS and YT Music icons and images - #47192
Conversation
Add two new React SVG icon components (SqlServerManagementStudio and YtMusic) to frontend/pages/SoftwarePage/components/icons and export them via the icons index. Include corresponding 2x app icon PNGs in website/assets/images and update the icons index file to expose the new icons for the Software page.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #47192 +/- ##
==========================================
- Coverage 67.19% 67.15% -0.04%
==========================================
Files 2946 2948 +2
Lines 226429 226433 +4
Branches 11683 11829 +146
==========================================
- Hits 152146 152072 -74
- Misses 60539 60622 +83
+ Partials 13744 13739 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (3)
WalkthroughThis PR extends the SoftwarePage icon library by adding two new software icons. It introduces Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds new software icons to the SoftwarePage icon set and wires them into the name→icon lookup map.
Changes:
- Added new icon components for “YouTube Music” and “SQL Server Management Studio”.
- Registered the new icons in
SOFTWARE_NAME_TO_ICON_MAP. - Updated the icons barrel (
index.ts) to export/import the new components.
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| frontend/pages/SoftwarePage/components/icons/index.ts | Adds imports and map entries for the two new software icons. |
| frontend/pages/SoftwarePage/components/icons/YtMusic.tsx | Introduces a YouTube Music icon component using an embedded base64 PNG inside an SVG. |
| frontend/pages/SoftwarePage/components/icons/SqlServerManagementStudio.tsx | Introduces an SSMS icon component using an embedded base64 PNG inside an SVG. |
Comments suppressed due to low confidence (1)
frontend/pages/SoftwarePage/components/icons/YtMusic.tsx:1
- Embedding a full base64-encoded PNG directly in the TSX component will significantly bloat the JS bundle (and slow down builds/parse time), since this string ships as code. Consider moving the bitmap to a static asset (e.g.,
public/), importing it as a URL, or replacing it with actual SVG path data; if you must keep a data URI, centralize/reuse it (and/or compress) to reduce duplication and diff noise.
import * as React from "react";
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <svg xmlns="http://www.w3.org/2000/svg" width={32} height={32} {...props}> | ||
| <image | ||
| width={32} | ||
| height={32} |
| import type { SVGProps } from "react"; | ||
|
|
||
| const YtMusic = (props: SVGProps<SVGSVGElement>) => ( | ||
| <svg xmlns="http://www.w3.org/2000/svg" width={32} height={32} {...props}> |
| <svg xmlns="http://www.w3.org/2000/svg" width={32} height={32} {...props}> | ||
| <image | ||
| width={32} | ||
| height={32} |
| import type { SVGProps } from "react"; | ||
|
|
||
| const SqlServerManagementStudio = (props: SVGProps<SVGSVGElement>) => ( | ||
| <svg xmlns="http://www.w3.org/2000/svg" width={32} height={32} {...props}> |
|
|
||
| import type { SVGProps } from "react"; | ||
|
|
||
| const YtMusic = (props: SVGProps<SVGSVGElement>) => ( |
Add two new React SVG icon components (SqlServerManagementStudio and YtMusic) to frontend/pages/SoftwarePage/components/icons and export them via the icons index. Include corresponding 2x app icon PNGs in website/assets/images and update the icons index file to expose the new icons for the Software page.
Summary by CodeRabbit