Skip to content

tools: bump x/net and x/crypto to clear high-severity CVE alerts - #48822

Merged
georgekarrv merged 1 commit into
mainfrom
gkarr-resolve-scans-tools
Jul 7, 2026
Merged

tools: bump x/net and x/crypto to clear high-severity CVE alerts#48822
georgekarrv merged 1 commit into
mainfrom
gkarr-resolve-scans-tools

Conversation

@georgekarrv

@georgekarrv georgekarrv commented Jul 6, 2026

Copy link
Copy Markdown
Member

Related issue: NA — resolves high-severity code-scanning alerts in tools/

Bumps the outdated golang.org/x/net and golang.org/x/crypto indirect
dependencies in the four tools/ Go modules to clear 39 high-severity
code-scanning (SCA) alerts on main. Target versions match the root Fleet
module.

Module x/net x/crypto
tools/dibble v0.53.0 → v0.55.0 v0.50.0 → v0.52.0
tools/hangar v0.53.0 → v0.55.0 v0.50.0 → v0.52.0
tools/terraform v0.48.0 → v0.55.0 v0.46.0 → v0.52.0
tools/github-manage v0.38.0 → v0.55.0

CVEs cleared:

  • x/net v0.55.0: CVE-2026-25681, -27136, -33814, -39821, -42502
  • x/crypto v0.52.0: CVE-2026-39827, -39828, -39829, -39830, -39832, -39835, -42508, -46595, -46597

All four modules go mod verify clean and build. Dependency-only change to
internal dev tooling — no product code, no user-visible behavior.

The remaining 8 high-severity alerts in tools/ are OpenSSF Scorecard
"Binary-Artifacts" findings for embedded dibble seed installers; those are
tracked separately and not addressed here.

Checklist for submitter

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters.

Summary by CodeRabbit

  • Chores
    • Updated several bundled Go dependencies across internal tooling to newer versions.
    • This includes refreshes to common networking, cryptography, text, and system packages, plus one added telemetry-related dependency.
    • No user-facing features or behavior changes were introduced.

…alerts

Bump indirect deps in the dibble, hangar, terraform, and github-manage
tool modules to align with the root fleet module:

- golang.org/x/net -> v0.55.0 (CVE-2026-25681, -27136, -33814, -39821, -42502)
- golang.org/x/crypto -> v0.52.0 (CVE-2026-39827..-39835, -42508, -46595, -46597)

Resolves the 39 high-severity code-scanning alerts in tools/ that stem
from outdated x/net and x/crypto versions.
Copilot AI review requested due to automatic review settings July 6, 2026 22:23
@georgekarrv
georgekarrv requested a review from a team as a code owner July 6, 2026 22:23

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3e31a43f-edc7-445f-8737-ce41e990901a

📥 Commits

Reviewing files that changed from the base of the PR and between 2c383d7 and 426d84f.

⛔ Files ignored due to path filters (4)
  • tools/dibble/go.sum is excluded by !**/*.sum
  • tools/github-manage/go.sum is excluded by !**/*.sum
  • tools/hangar/go.sum is excluded by !**/*.sum
  • tools/terraform/go.sum is excluded by !**/*.sum
📒 Files selected for processing (4)
  • tools/dibble/go.mod
  • tools/github-manage/go.mod
  • tools/hangar/go.mod
  • tools/terraform/go.mod

Walkthrough

This PR updates go.mod files across four tool modules (tools/dibble, tools/github-manage, tools/hangar, tools/terraform), bumping various golang.org/x/* indirect dependency versions (crypto, image, net, sync, sys, term, text, mod, tools) to newer patch/minor releases. Additionally, tools/dibble/go.mod adds a new indirect dependency, go.opentelemetry.io/otel/sdk v1.43.0. No exported or public entity declarations were altered.

Possibly related PRs

  • fleetdm/fleet#46949: Bumps the same golang.org/x/* dependencies (x/crypto, x/net, x/sys, x/term, x/text) in go.mod files.
  • fleetdm/fleet#48345: Updates golang.org/x/image and related golang.org/x/* module versions in go.mod files.
  • fleetdm/fleet#48461: Also touches tools/dibble/go.mod, updating the go version directive alongside dependency changes.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: updating tools module dependencies, especially x/net and x/crypto, to address high-severity CVE alerts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch gkarr-resolve-scans-tools

Warning

Tools execution failed with the following error:

Failed to run tools: Stream initialization permanently failed: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates indirect golang.org/x/net and golang.org/x/crypto dependencies across the Go modules under tools/ to match the root Fleet module and clear high-severity code-scanning alerts for internal tooling.

Changes:

  • Bump golang.org/x/net to v0.55.0 in tools/dibble, tools/hangar, tools/terraform, and tools/github-manage.
  • Bump golang.org/x/crypto to v0.52.0 in tools/dibble, tools/hangar, and tools/terraform.
  • Refresh corresponding go.sum entries (and related transitive x/* modules) as a result of the dependency updates.

Reviewed changes

Copilot reviewed 4 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tools/terraform/go.mod Updates indirect x/* versions including x/net and x/crypto for the terraform tooling module.
tools/terraform/go.sum Updates checksums to match the new go.mod dependency graph.
tools/hangar/go.mod Bumps indirect x/net/x/crypto (and x/sys) for the hangar tooling module.
tools/hangar/go.sum Updates checksums to match the bumped x/* dependencies.
tools/github-manage/go.mod Bumps indirect x/net (plus related x/*) for the GitHub management tooling module.
tools/github-manage/go.sum Updates checksums to match the updated indirect x/* dependencies.
tools/dibble/go.mod Bumps indirect x/net/x/crypto (plus related x/*) for the dibble tooling module.
tools/dibble/go.sum Updates checksums to match the updated dependency graph.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@georgekarrv
georgekarrv merged commit af51636 into main Jul 7, 2026
10 checks passed
@georgekarrv
georgekarrv deleted the gkarr-resolve-scans-tools branch July 7, 2026 16:25
@coderabbitai coderabbitai Bot mentioned this pull request Jul 9, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants