Skip to content

Include new tools in update-go and fix dibble - #48461

Merged
georgekarrv merged 1 commit into
mainfrom
gkarr-fix-go-update
Jun 30, 2026
Merged

Include new tools in update-go and fix dibble#48461
georgekarrv merged 1 commit into
mainfrom
gkarr-fix-go-update

Conversation

@georgekarrv

@georgekarrv georgekarrv commented Jun 29, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated the project’s Go version settings to keep tooling in sync across all relevant components.
    • Running the standard Go update workflow will now apply version updates to an additional part of the codebase.

@georgekarrv
georgekarrv requested a review from a team as a code owner June 29, 2026 22:00
Copilot AI review requested due to automatic review settings June 29, 2026 22:00

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns the dibble tool module with the repo’s Go version and ensures it’s included in the make update-go automation so future Go bumps update it alongside other submodules.

Changes:

  • Bumped tools/dibble module go directive from 1.26.3 to 1.26.4 to match the main module.
  • Added ./tools/dibble/go.mod to UPDATE_GO_MODS so make update-go updates it automatically.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tools/dibble/go.mod Updates the module’s Go version to match the repo’s current Go directive.
Makefile Ensures make update-go includes tools/dibble/go.mod in its bulk Go-version updates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 82b5628f-9f39-44fb-bd3c-88ccedf93e98

📥 Commits

Reviewing files that changed from the base of the PR and between 9a6d575 and ed5b8f9.

📒 Files selected for processing (2)
  • Makefile
  • tools/dibble/go.mod

Walkthrough

The Go version directive in tools/dibble/go.mod is updated from 1.26.3 to 1.26.4. Additionally, ./tools/dibble/go.mod is added to the UPDATE_GO_MODS variable in the Makefile, so the make update-go target will include this module in future Go version updates.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning No PR description was provided, so the required template sections and checklist items are missing. Fill in the template sections, especially Related issue, Testing, and any applicable checklist items, or delete non-applicable sections.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: adding dibble to update-go and updating its Go version.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch gkarr-fix-go-update

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@georgekarrv
georgekarrv merged commit 92c4e28 into main Jun 30, 2026
10 checks passed
@georgekarrv
georgekarrv deleted the gkarr-fix-go-update branch June 30, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants