Update go to 1.26.5 - #48993
Conversation
There was a problem hiding this comment.
Warning
- Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.
Pull request overview
Updates Fleet’s pinned Go toolchain version to 1.26.5 across the main module, supporting tool modules, and Docker builder images, aligning with the goal in #48988. It also enhances make update-go to automatically resolve and pin Docker image digests (but currently uses a likely-wrong buildx imagetools inspect template field).
Changes:
- Bumped
godirectives in the root module and multipletools/+third_party/modules togo 1.26.5. - Updated Golang builder image tags + digests in relevant Dockerfiles to
1.26.5. - Updated the
update-goMakefile target to automatically resolve and rewrite image digests, and added an Orbit changelog entry for the bump.
Reviewed changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Bump root module Go directive to 1.26.5. |
| Dockerfile-desktop-linux | Update Golang builder image to 1.26.5 with new pinned digest. |
| infrastructure/loadtesting/terraform/docker/loadtest.Dockerfile | Update Golang builder image to 1.26.5 with new pinned digest. |
| tools/mdm/migration/mdmproxy/Dockerfile | Update Golang builder image to 1.26.5 with new pinned digest. |
| Makefile | Expand update-go scope and add digest auto-resolution logic. |
| third_party/vuln-check/go.mod | Bump Go directive to 1.26.5. |
| third_party/goval-dictionary/go.mod | Bump Go directive to 1.26.5. |
| tools/ci/apiparamcheck/go.mod | Bump Go directive to 1.26.5. |
| tools/ci/setboolcheck/go.mod | Bump Go directive to 1.26.5. |
| tools/github-manage/go.mod | Bump Go directive to 1.26.5. |
| tools/qacheck/go.mod | Bump Go directive to 1.26.5. |
| tools/snapshot/go.mod | Bump Go directive to 1.26.5. |
| tools/terraform/go.mod | Bump Go directive to 1.26.5. |
| tools/mdm/windows/bitlocker/go.mod | Bump Go directive to 1.26.5. |
| tools/fleet-mcp/go.mod | Bump Go directive to 1.26.5. |
| tools/dibble/go.mod | Bump Go directive to 1.26.5. |
| tools/screencap/go.mod | Bump Go directive to 1.26.5. |
| tools/hangar/go.mod | Bump Go directive to 1.26.5. |
| orbit/changes/update-go-1.26.5 | Add Orbit changelog entry for the Go bump. |
| changes/update-go-1.26.5 | Changelog entry for the bump (content excluded from review). |
Files excluded by content exclusion policy (1)
- changes/update-go-1.26.5
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #48993 +/- ##
==========================================
- Coverage 68.11% 68.11% -0.01%
==========================================
Files 3730 3730
Lines 235229 235426 +197
Branches 12332 12332
==========================================
+ Hits 160236 160360 +124
- Misses 60618 60673 +55
- Partials 14375 14393 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
WalkthroughThis PR updates Go version references to 1.26.5 across the root module, selected third-party and tools modules, Docker builder images, Makefile update automation, and changelog entries. It also expands the Makefile’s managed go.mod list and changes the Dockerfile update flow to resolve and pin golang image digests automatically. Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
Makefile (1)
1053-1067: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winAdd the missing module files to
UPDATE_GO_MODS.docs/go.mod,handbook/go.mod, andwebsite/go.modare present in the repo but not included here, somake update-gowon’t bump their Go version.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Makefile` around lines 1053 - 1067, Add the missing module manifests to UPDATE_GO_MODS in the Makefile so `make update-go` updates every tracked Go module; include `docs/go.mod`, `handbook/go.mod`, and `website/go.mod` alongside the existing entries in the UPDATE_GO_MODS list. Keep the change limited to the module list definition so the update workflow covers all repo modules consistently.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@Makefile`:
- Around line 1053-1067: Add the missing module manifests to UPDATE_GO_MODS in
the Makefile so `make update-go` updates every tracked Go module; include
`docs/go.mod`, `handbook/go.mod`, and `website/go.mod` alongside the existing
entries in the UPDATE_GO_MODS list. Keep the change limited to the module list
definition so the update workflow covers all repo modules consistently.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4f74754a-663e-4cea-a037-7be0f25c35ad
📒 Files selected for processing (20)
Dockerfile-desktop-linuxMakefilechanges/update-go-1.26.5go.modinfrastructure/loadtesting/terraform/docker/loadtest.Dockerfileorbit/changes/update-go-1.26.5third_party/goval-dictionary/go.modthird_party/vuln-check/go.modtools/ci/apiparamcheck/go.modtools/ci/setboolcheck/go.modtools/dibble/go.modtools/fleet-mcp/go.modtools/github-manage/go.modtools/hangar/go.modtools/mdm/migration/mdmproxy/Dockerfiletools/mdm/windows/bitlocker/go.modtools/qacheck/go.modtools/screencap/go.modtools/snapshot/go.modtools/terraform/go.mod
Cherry-pick of #48993 into the RC branch. **Conflict resolved:** `Makefile` `UPDATE_GO_MODS` list — took the union of both sides. The RC branch had added `third_party/goval-dictionary/go.mod`; #48993 added `screencap`, `hangar`, and `dibble`. All are kept (the resulting list is a superset containing every module from both branches). Co-authored-by: Lucas Manuel Rodriguez <lucas@fleetdm.com>
Cherry-pick of #48993 into the rc-minor-fleetd-v1.58.0 RC branch.
Resolves #48988.
I ran
make update-go version=1.26.5.changes/,orbit/changes/oree/fleetd-chrome/changes.Testing
Fleet:

fleetctl:
Also verified orbit in Linux:

fleetd/orbit/Fleet Desktop
Summary by CodeRabbit
Chores
Bug Fixes