macOS FMA - Antigravity - #47010
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #47010 +/- ##
==========================================
- Coverage 67.04% 67.04% -0.01%
==========================================
Files 2869 2876 +7
Lines 225121 225135 +14
Branches 11600 11600
==========================================
+ Hits 150926 150933 +7
- Misses 60525 60532 +7
Partials 13670 13670
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR adds Google Antigravity to Fleet's maintained-apps system by: introducing a Homebrew input manifest; creating a darwin output manifest (version detection, DMG installer metadata, and install/uninstall scripts); registering the app in ee/maintained-apps/outputs/apps.json; and adding a branded frontend icon component plus SOFTWARE_NAME_TO_ICON_MAP entries for name matching. Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ee/maintained-apps/outputs/antigravity/darwin.json`:
- Around line 19-20: Both install and uninstall scripts can mask failures
because they don't fail-fast; add explicit existence and error checks: in the
install flow (symbols: TMPDIR, MOUNT_POINT, quit_and_track_application,
relaunch_application) verify the mounted payload exists (e.g. [[ -d
"$TMPDIR/Antigravity.app" ]]) and exit non-zero with an error message if
missing, and after sudo cp -R check that the copy succeeded and that
$APPDIR/Antigravity.app exists otherwise exit with a failure; in the uninstall
flow (symbols: quit_application, trash) run sudo rm -rf
"$APPDIR/Antigravity.app" then verify [[ ! -e "$APPDIR/Antigravity.app" ]] and
exit non-zero with an error message if the app still exists so removals and
installs don't report success when they failed.
In `@frontend/pages/SoftwarePage/components/icons/index.ts`:
- Line 336: The icon map's key "antigravity" doesn't match the normalized
runtime name "google antigravity" used by matchLoosePrefixToKey, so add an alias
mapping for the runtime name (e.g., add "google antigravity": Antigravity) next
to the existing antigravity: Antigravity entry in the icons object (or
rename/augment the key to include the "google" prefix) so the lookup in
matchLoosePrefixToKey will correctly resolve the Antigravity component for the
"Google Antigravity" app from apps.json.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a8815fda-766c-4c4d-a8fc-2abde4ab1688
⛔ Files ignored due to path filters (1)
website/assets/images/app-icon-antigravity-60x60@2x.pngis excluded by!**/*.png
📒 Files selected for processing (5)
ee/maintained-apps/inputs/homebrew/antigravity.jsonee/maintained-apps/outputs/antigravity/darwin.jsonee/maintained-apps/outputs/apps.jsonfrontend/pages/SoftwarePage/components/icons/Antigravity.tsxfrontend/pages/SoftwarePage/components/icons/index.ts
Summary by CodeRabbit