Update Fleet-maintained apps - #47036
Conversation
Generated automatically with cmd/maintained-apps.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
WalkthroughThis PR updates three maintained macOS app definitions. Comet is adjusted from version 148.0.7778.1016 to 145.2.7632.4581 with corresponding SQL query updates. Kitty is bumped from 0.47.1 to 0.47.2, including installer URL and checksum updates. Stats is upgraded from 2.12.16 to 3.0.0 with version metadata changes and a refactored install script that uses new helper functions, improves DMG handling with backup logic, and adds root-aware session management for relaunching the application. Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ee/maintained-apps/outputs/stats/darwin.json (1)
20-20:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd rollback when new app copy fails after moving existing
Stats.app.At Line 20 (embedded install script), the old app is moved to
Stats.app.bkpbefore install, but a failedcpleaves the app absent with no restore path.Proposed fix
- if [ -d "$APPDIR/Stats.app" ]; then - sudo mv "$APPDIR/Stats.app" "$TMPDIR/Stats.app.bkp" - fi - sudo cp -R "$TMPDIR/Stats.app" "$APPDIR" + had_backup=0 + if [ -d "$APPDIR/Stats.app" ]; then + sudo mv "$APPDIR/Stats.app" "$TMPDIR/Stats.app.bkp" + had_backup=1 + fi + + if ! sudo cp -R "$TMPDIR/Stats.app" "$APPDIR"; then + echo "Failed to install new Stats.app" + if [ "$had_backup" -eq 1 ] && [ -d "$TMPDIR/Stats.app.bkp" ]; then + sudo mv "$TMPDIR/Stats.app.bkp" "$APPDIR/Stats.app" + echo "Restored previous Stats.app from backup." + fi + exit 1 + fi🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ee/maintained-apps/outputs/stats/darwin.json` at line 20, The install script moves the existing app to a backup ("sudo mv \"$APPDIR/Stats.app\" \"$TMPDIR/Stats.app.bkp\"") and then copies the new app, but if the subsequent sudo cp -R "$TMPDIR/Stats.app" "$APPDIR" fails the original is lost; update the install sequence to perform the copy first into a temporary location (or check cp exit status) and, on cp failure, restore the backup by moving "$TMPDIR/Stats.app.bkp" back to "$APPDIR/Stats.app" and remove the failed partial copy; ensure you handle errors and exit non‑zero when both copy and restore fail, referencing the existing logic around quit_and_track_application and relaunch_application so relaunch only runs after successful install.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@ee/maintained-apps/outputs/stats/darwin.json`:
- Line 20: The install script moves the existing app to a backup ("sudo mv
\"$APPDIR/Stats.app\" \"$TMPDIR/Stats.app.bkp\"") and then copies the new app,
but if the subsequent sudo cp -R "$TMPDIR/Stats.app" "$APPDIR" fails the
original is lost; update the install sequence to perform the copy first into a
temporary location (or check cp exit status) and, on cp failure, restore the
backup by moving "$TMPDIR/Stats.app.bkp" back to "$APPDIR/Stats.app" and remove
the failed partial copy; ensure you handle errors and exit non‑zero when both
copy and restore fail, referencing the existing logic around
quit_and_track_application and relaunch_application so relaunch only runs after
successful install.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4b52c5de-49a9-4bbc-82ff-f54a6bcbcc25
📒 Files selected for processing (3)
ee/maintained-apps/outputs/comet/darwin.jsonee/maintained-apps/outputs/kitty/darwin.jsonee/maintained-apps/outputs/stats/darwin.json
|
Closing in favor of #47038. |
2 participants
Automated ingestion of latest Fleet-maintained app data.
Summary by CodeRabbit
Release Notes