Skip to content

Update Fleet-maintained apps - #47038

Closed
fleet-release wants to merge 1 commit into
mainfrom
fma-2606071627
Closed

Update Fleet-maintained apps#47038
fleet-release wants to merge 1 commit into
mainfrom
fma-2606071627

Conversation

@fleet-release

@fleet-release fleet-release commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Automated ingestion of latest Fleet-maintained app data.

Summary by CodeRabbit

Chores

  • Updated metadata for maintained macOS applications to reference newer versions:
    • Comet: Browser version reference updated
    • Kitty: Application version updated to 0.47.2
    • Stats: Application version updated to 3.0.0

Generated automatically with cmd/maintained-apps.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

This PR updates version metadata for three macOS applications in the Fleet maintained apps registry. Comet is pinned to version 145.2.7632.4581, Kitty is upgraded to version 0.47.2, and Stats is upgraded to version 3.0.0. Each update modifies the corresponding patched SQL query version comparison, installer URL, and SHA256 checksum for the DMG package.

Possibly related PRs

  • fleetdm/fleet#46817: Updates macOS ee/maintained-apps/outputs/*/darwin.json metadata with the same pattern of version bumps, patched query adjustments, and installer URL/checksum updates.
  • fleetdm/fleet#45680: Updates the same ee/maintained-apps/outputs/stats/darwin.json file for the Stats app by changing version reference and related installer metadata.
  • fleetdm/fleet#46586: Similar data-only version bumps in ee/maintained-apps/outputs/*/darwin.json files with updates to version fields, patched query targets, and checksum values.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Update Fleet-maintained apps' is generic and does not clearly convey the specific changes made to three macOS app versions (Comet, Kitty, and Stats). Consider a more descriptive title that specifies the apps or versions being updated, such as 'Update Fleet-maintained app versions' or 'Update Comet, Kitty, and Stats macOS metadata'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fma-2606071627

Warning

Tools execution failed with the following error:

Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ee/maintained-apps/outputs/comet/darwin.json`:
- Around line 4-7: The "version" value was changed to "145.2.7632.4581" and is
used in the "patched" query via version_compare(..., '145.2.7632.4581') < 0,
which lowers the enforced baseline; verify the intended baseline and either
revert the "version" value to the original threshold (e.g., the previous
"148.0.7778.1016") or update the "patched" predicate to use the correct baseline
consistently; specifically inspect and update the "version" key and the
"queries.patched" string (the version_compare call and bundle_identifier
'ai.perplexity.comet') so the compliance gating reflects the intended minimum
version.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4ee60244-e455-4d23-a447-6870e1a36bc5

📥 Commits

Reviewing files that changed from the base of the PR and between b1395ed and 24052fa.

📒 Files selected for processing (3)
  • ee/maintained-apps/outputs/comet/darwin.json
  • ee/maintained-apps/outputs/kitty/darwin.json
  • ee/maintained-apps/outputs/stats/darwin.json

Comment on lines +4 to +7
"version": "145.2.7632.4581",
"queries": {
"exists": "SELECT 1 FROM apps WHERE bundle_identifier = 'ai.perplexity.comet';",
"patched": "SELECT 1 WHERE NOT EXISTS (SELECT 1 FROM apps WHERE bundle_identifier = 'ai.perplexity.comet' AND version_compare(bundle_short_version, '148.0.7778.1016') < 0);"
"patched": "SELECT 1 WHERE NOT EXISTS (SELECT 1 FROM apps WHERE bundle_identifier = 'ai.perplexity.comet' AND version_compare(bundle_short_version, '145.2.7632.4581') < 0);"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

❓ Verification inconclusive

🏁 Script executed:

#!/bin/bash
# Verify whether this PR lowered the Comet maintained-app threshold and by how much.
# Expected: output should clearly show old->new for version and patched query.

set -euo pipefail

FILE="ee/maintained-apps/outputs/comet/darwin.json"

echo "Current file values:"
rg -n '"version"|"patched"' "$FILE"

echo
echo "Previous commit values (if available in local clone):"
git show HEAD~1:"$FILE" | rg -n '"version"|"patched"' || {
  echo "Unable to read HEAD~1 for this file; verify PR base diff in GitHub UI."
}

Repository: fleetdm/fleet

Length of output: 1929


🏁 Script executed:

#!/bin/bash
set -euo pipefail

FILE="ee/maintained-apps/outputs/comet/darwin.json"

echo "Current:"
rg -n '"version"|"patched"' "$FILE"

echo
echo "Previous (requires repo history available locally):"
if git rev-parse --verify HEAD~1 >/dev/null 2>&1; then
  git show HEAD~1:"$FILE" | rg -n '"version"|"patched"'
else
  echo "HEAD~1 not available; compare against the PR base commit (git diff in your local clone or GitHub UI)."
fi

Repository: fleetdm/fleet

Length of output: 1948


🏁 Script executed:

#!/bin/bash
set -euo pipefail

FILE="ee/maintained-apps/outputs/comet/darwin.json"

echo "Current:"
rg -n '"version"|"patched"' "$FILE"

echo
echo "Previous revision (use PR base/merge-base locally if HEAD~1 isn't the prior state):"
git show HEAD~1:"$FILE" 2>/dev/null | rg -n '"version"|"patched"' || {
  echo "Unable to read HEAD~1. Compare against the PR base commit locally (git show <base>:$FILE)."
}

Repository: fleetdm/fleet

Length of output: 1948


🏁 Script executed:

#!/bin/bash
set -euo pipefail
FILE="ee/maintained-apps/outputs/comet/darwin.json"

echo "Current (post-PR):"
rg -n '"version"|"patched"' "$FILE"

echo
echo "Compare against the PR base commit locally (git show <base_sha>:$FILE) and ensure the 'version' value didn't get reduced unintentionally."

Repository: fleetdm/fleet

Length of output: 1948


Potential Comet patched baseline regression—confirm the enforced version threshold change
ee/maintained-apps/outputs/comet/darwin.json now sets "version": "145.2.7632.4581" and uses it in the patched predicate (version_compare(..., '145.2.7632.4581') < 0). If the PR lowered the baseline from 148.0.7778.1016 to 145.2.7632.4581, compliance gating could be weakened by classifying more “older” hosts as patched.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ee/maintained-apps/outputs/comet/darwin.json` around lines 4 - 7, The
"version" value was changed to "145.2.7632.4581" and is used in the "patched"
query via version_compare(..., '145.2.7632.4581') < 0, which lowers the enforced
baseline; verify the intended baseline and either revert the "version" value to
the original threshold (e.g., the previous "148.0.7778.1016") or update the
"patched" predicate to use the correct baseline consistently; specifically
inspect and update the "version" key and the "queries.patched" string (the
version_compare call and bundle_identifier 'ai.perplexity.comet') so the
compliance gating reflects the intended minimum version.

@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Closing in favor of #47040.

@github-actions github-actions Bot closed this Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants