Update Fleet-maintained apps - #47034
Conversation
Generated automatically with cmd/maintained-apps.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
WalkthroughThis PR updates version metadata for two maintained macOS applications in the Fleet repository. The Comet entry is bumped to version 145.2.7632.4581 with corresponding patched query adjustments. The Kitty entry is bumped to version 0.47.2, including updates to the patched query threshold, installer URL for the v0.47.2 DMG release, and the associated sha256 checksum verification. Both changes follow the same maintained-app update pattern without modifications to installation/uninstallation script references or other configuration. Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ee/maintained-apps/outputs/comet/darwin.json`:
- Line 4: Update the "version" value in the Comet darwin.json from
"145.2.7632.4581" to "148.0.7778.1016" so the patched check using
version_compare(bundle_short_version, "148.0.7778.1016") correctly identifies
installs older than the intended stable installer (installer_url redirecting to
the 148.0.7778.1016 DMG); ensure the "version" key and any version_compare
usages reference "148.0.7778.1016" consistently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: bb5dee42-8093-4fe0-b96a-430e80040c46
📒 Files selected for processing (2)
ee/maintained-apps/outputs/comet/darwin.jsonee/maintained-apps/outputs/kitty/darwin.json
| "versions": [ | ||
| { | ||
| "version": "148.0.7778.1016", | ||
| "version": "145.2.7632.4581", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify the latest Comet version from Perplexity's download endpoint
# Check the actual download to see version metadata or filename
curl -sL -D - "https://www.perplexity.ai/rest/browser/download?channel=stable&platform=mac_arm64" -o /tmp/comet_check.dmg 2>&1 | head -20
# Check if we can extract version info from the DMG
if [ -f /tmp/comet_check.dmg ]; then
file /tmp/comet_check.dmg
ls -lh /tmp/comet_check.dmg
fiRepository: fleetdm/fleet
Length of output: 1691
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Show the relevant portion of the target JSON with line numbers
nl -ba ee/maintained-apps/outputs/comet/darwin.json | sed -n '1,80p'
# Also search for any other version mentions in the same file
rg -n '"version"|bundle_short_version|145\.2\.7632\.4581|148\.0\.7778\.1016' ee/maintained-apps/outputs/comet/darwin.jsonRepository: fleetdm/fleet
Length of output: 100
🏁 Script executed:
#!/bin/bash
set -euo pipefail
nl -ba ee/maintained-apps/outputs/comet/darwin.json | sed -n '1,120p'
rg -n '"version"|bundle_short_version|145\.2\.7632\.4581|148\.0\.7778\.1016' ee/maintained-apps/outputs/comet/darwin.jsonRepository: fleetdm/fleet
Length of output: 100
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Print the beginning of the JSON with line numbers (nl is unavailable in this sandbox)
cat -n ee/maintained-apps/outputs/comet/darwin.json | sed -n '1,120p'
# Search for version strings in the file
rg -n '"version"|bundle_short_version|145\.2\.7632\.4581|148\.0\.7778\.1016' ee/maintained-apps/outputs/comet/darwin.jsonRepository: fleetdm/fleet
Length of output: 7076
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n "version_compare\s*\(" -S . | head -50Repository: fleetdm/fleet
Length of output: 11047
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n "func\s+version_compare|version_compare" -S ee server internal cmd . | head -50Repository: fleetdm/fleet
Length of output: 11547
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n "version_compare\s*\(" -S . | head -80Repository: fleetdm/fleet
Length of output: 17984
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n "version_compare" -S . | head -80Repository: fleetdm/fleet
Length of output: 18040
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n "version_compare\s*\(" -S . | head -80Repository: fleetdm/fleet
Length of output: 17864
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n "version_compare" -S . | head -120Repository: fleetdm/fleet
Length of output: 27278
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n "version_compare\s*\(" -S . | head -80Repository: fleetdm/fleet
Length of output: 18167
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n "version_compare" -S . | head -120Repository: fleetdm/fleet
Length of output: 27359
🌐 Web query:
osquery version_compare semantics return value negative positive when comparing versions
💡 Result:
In osquery, the version_compare(left_version, right_version, [compare_flavor]) function returns the following integer values based on the comparison of the two provided version strings [1][2]: - -1: Returned if the left_version is less than the right_version [1][2]. - 0: Returned if the left_version and right_version are equal [1][2]. - 1: Returned if the left_version is greater than the right_version [1][2]. The optional compare_flavor argument allows for specific package manager versioning logic (e.g., ARCH, DPKG, or RHEL); if omitted, it defaults to semantic versioning [1][2].
Citations:
- 1: https://osquery.readthedocs.io/en/latest/introduction/sql/
- 2: https://osquery.readthedocs.io/en/5.16.0/introduction/sql/
Major: Comet version in darwin.json appears to be a rollback vs the stable “latest” binary.
ee/maintained-apps/outputs/comet/darwin.json sets "version": "145.2.7632.4581" and the patched query marks the app as patched when bundle_short_version is not < 145.2.7632.4581 (version_compare(..., ...) < 0 is true only when the installed version is lower). This would prevent updates from reaching the newer 148.0.7778.1016 on hosts where Comet is already at (or above) 148.
The installer_url (.../rest/browser/download?channel=stable&platform=mac_arm64) redirects to a DMG path containing 148.0.7778.1016/comet_latest.dmg, so the desired version/version_compare target should match 148.0.7778.1016 rather than 145.2.7632.4581.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ee/maintained-apps/outputs/comet/darwin.json` at line 4, Update the "version"
value in the Comet darwin.json from "145.2.7632.4581" to "148.0.7778.1016" so
the patched check using version_compare(bundle_short_version, "148.0.7778.1016")
correctly identifies installs older than the intended stable installer
(installer_url redirecting to the 148.0.7778.1016 DMG); ensure the "version" key
and any version_compare usages reference "148.0.7778.1016" consistently.
|
Closing in favor of #47035. |
|
Closing in favor of #47036. |
2 participants
Automated ingestion of latest Fleet-maintained app data.
Summary by CodeRabbit