Skip to content

Add Amazon Corretto 21/24/26 Windows apps - #46875

Merged
allenhouchins merged 1 commit into
mainfrom
allenhouchins-amazon-corretto
Jun 5, 2026
Merged

Add Amazon Corretto 21/24/26 Windows apps#46875
allenhouchins merged 1 commit into
mainfrom
allenhouchins-amazon-corretto

Conversation

@allenhouchins

@allenhouchins allenhouchins commented Jun 5, 2026

Copy link
Copy Markdown
Member

Add support for Amazon Corretto JDKs (21, 24, 26) on Windows: new winget input manifests and outputs with installer URLs, SHA256s, existence/patch queries, upgrade codes, and install/uninstall script refs. Update maintained apps index (apps.json) to include the three new Corretto entries. Add frontend icon components for Corretto 21/24/26 and update icon exports.

Summary by CodeRabbit

Release Notes

  • New Features
    • Added support for three new Amazon Corretto Java versions (21, 24, and 26) on Windows x64
    • Enables automatic detection of existing installations with version comparison
    • Supports silent installation and uninstallation capabilities
    • Includes frontend icons and software catalog entries for easy discovery

Add support for Amazon Corretto JDKs (21, 24, 26) on Windows: new winget input manifests and outputs with installer URLs, SHA256s, existence/patch queries, upgrade codes, and install/uninstall script refs. Update maintained apps index (apps.json) to include the three new Corretto entries. Add frontend icon components for Corretto 21/24/26 and update icon exports.
@codecov

codecov Bot commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.96%. Comparing base (1582252) to head (53a896d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...SoftwarePage/components/icons/AmazonCorretto21.tsx 50.00% 1 Missing ⚠️
...SoftwarePage/components/icons/AmazonCorretto24.tsx 50.00% 1 Missing ⚠️
...SoftwarePage/components/icons/AmazonCorretto26.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #46875      +/-   ##
==========================================
- Coverage   66.96%   66.96%   -0.01%     
==========================================
  Files        2853     2856       +3     
  Lines      225666   225672       +6     
  Branches    11592    11733     +141     
==========================================
+ Hits       151123   151126       +3     
- Misses      60836    60839       +3     
  Partials    13707    13707              
Flag Coverage Δ
frontend 56.96% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@allenhouchins
allenhouchins marked this pull request as ready for review June 5, 2026 04:08
Copilot AI review requested due to automatic review settings June 5, 2026 04:08
@allenhouchins
allenhouchins requested a review from a team as a code owner June 5, 2026 04:08

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@allenhouchins
allenhouchins merged commit 7a78d05 into main Jun 5, 2026
28 of 29 checks passed
@allenhouchins
allenhouchins deleted the allenhouchins-amazon-corretto branch June 5, 2026 04:08
@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7b55593b-d97b-48e7-8e63-e300c8b35c56

📥 Commits

Reviewing files that changed from the base of the PR and between 1582252 and 53a896d.

📒 Files selected for processing (11)
  • ee/maintained-apps/inputs/winget/amazon-corretto-21.json
  • ee/maintained-apps/inputs/winget/amazon-corretto-24.json
  • ee/maintained-apps/inputs/winget/amazon-corretto-26.json
  • ee/maintained-apps/outputs/amazon-corretto-21/windows.json
  • ee/maintained-apps/outputs/amazon-corretto-24/windows.json
  • ee/maintained-apps/outputs/amazon-corretto-26/windows.json
  • ee/maintained-apps/outputs/apps.json
  • frontend/pages/SoftwarePage/components/icons/AmazonCorretto21.tsx
  • frontend/pages/SoftwarePage/components/icons/AmazonCorretto24.tsx
  • frontend/pages/SoftwarePage/components/icons/AmazonCorretto26.tsx
  • frontend/pages/SoftwarePage/components/icons/index.ts

Walkthrough

This PR extends Fleet's software library with three new Amazon Corretto Java runtime versions (21, 24, 26). It adds Winget input manifests defining package detection logic, Windows installation specifications with embedded PowerShell install/uninstall scripts for silent MSI deployment, registers the applications in the main app catalog, and implements frontend React icon components with icon-to-name mappings to display them in the UI.

Possibly related PRs

  • fleetdm/fleet#46381: Both PRs extend frontend/pages/SoftwarePage/components/icons/index.ts with new application-to-icon mappings for multi-version Java runtimes.
  • fleetdm/fleet#46426: Both PRs modify the same frontend icon registry to add software-to-icon name mappings for new applications.
  • fleetdm/fleet#46259: Both PRs follow the same structural pattern of adding new Windows FMAs by creating corresponding input/output manifests and updating the apps.json registry.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch allenhouchins-amazon-corretto

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Amazon Corretto JDK (21/24/26) as Fleet-maintained Windows apps (winget-backed) and wires up corresponding Software page icons so these new app entries render with a Corretto icon in the UI.

Changes:

  • Added new winget input manifests and generated Windows outputs for Amazon Corretto 21/24/26 (including installer URL/SHA, detection & patch queries, upgrade codes, and install/uninstall script refs).
  • Updated the maintained-apps index (apps.json) to include the new Corretto entries.
  • Added Amazon Corretto 21/24/26 icon components and mapped them in the Software icons index.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
frontend/pages/SoftwarePage/components/icons/index.ts Registers Corretto 21/24/26 icon imports and name→icon mappings.
frontend/pages/SoftwarePage/components/icons/AmazonCorretto21.tsx Adds Corretto 21 icon component (embedded PNG-in-SVG).
frontend/pages/SoftwarePage/components/icons/AmazonCorretto24.tsx Adds Corretto 24 icon component (embedded PNG-in-SVG).
frontend/pages/SoftwarePage/components/icons/AmazonCorretto26.tsx Adds Corretto 26 icon component (embedded PNG-in-SVG).
ee/maintained-apps/outputs/apps.json Adds Corretto 21/24/26 entries to the maintained apps index.
ee/maintained-apps/outputs/amazon-corretto-21/windows.json Generated Windows output manifest for Corretto 21.
ee/maintained-apps/outputs/amazon-corretto-24/windows.json Generated Windows output manifest for Corretto 24.
ee/maintained-apps/outputs/amazon-corretto-26/windows.json Generated Windows output manifest for Corretto 26.
ee/maintained-apps/inputs/winget/amazon-corretto-21.json New winget input manifest for Corretto 21.
ee/maintained-apps/inputs/winget/amazon-corretto-24.json New winget input manifest for Corretto 24.
ee/maintained-apps/inputs/winget/amazon-corretto-26.json New winget input manifest for Corretto 26.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +8 to +11
import AmazonCorretto21 from "./AmazonCorretto21";
import AmazonCorretto24 from "./AmazonCorretto24";
import AmazonCorretto25 from "./AmazonCorretto25";
import AmazonCorretto26 from "./AmazonCorretto26";
Comment on lines +318 to +321
"amazon corretto 21": AmazonCorretto21,
"amazon corretto 24": AmazonCorretto24,
"amazon corretto 25": AmazonCorretto25,
"amazon corretto 26": AmazonCorretto26,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants