Add Groove OmniDialer as a macOS FMA - #47020
Conversation
Introduce Groove OmniDialer to the maintained apps dataset and UI. Adds a homebrew input (dmg) and an apps.json entry, plus a darwin-specific output with version 26.603.1017, installer URL, sha256, and embedded install/uninstall script refs. Also adds a frontend SVG icon component, registers it in the icons index, and includes the app PNG asset. Install/uninstall scripts handle quitting/relaunching the app and cleaning user data.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #47020 +/- ##
==========================================
- Coverage 67.04% 67.04% -0.01%
==========================================
Files 2872 2873 +1
Lines 225127 225129 +2
Branches 11742 11743 +1
==========================================
+ Hits 150929 150930 +1
Misses 60528 60528
- Partials 13670 13671 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
WalkthroughThis PR adds complete integration for Groove OmniDialer, a macOS communication application. The change includes: (1) new homebrew input metadata defining the app's unique identifiers, installer format, and darwin slug; (2) a new entry in the apps catalog registering the application on darwin platform; (3) a darwin-specific version configuration with embedded bash scripts for installation (DMG mount/copy with app relaunching and GUI session handling) and uninstallation (app removal and user data cleanup); and (4) a new React SVG icon component wired into the frontend icon registry to display the application in the software browser. Possibly related issues
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR adds Groove OmniDialer as a Fleet-maintained app (macOS), wiring it into the maintained apps dataset (inputs + outputs + apps list) and adding a corresponding Software page icon so it renders correctly in the UI.
Changes:
- Add Groove OmniDialer to the maintained apps catalog (
apps.json) and Homebrew input definition. - Add the macOS maintained-app output manifest (
darwin.json) including exists/patched queries, installer URL+sha256, and install/uninstall script refs. - Add a new frontend icon component and register it in the software-name-to-icon map.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/pages/SoftwarePage/components/icons/index.ts | Registers the new Groove OmniDialer icon and maps it to the normalized software name. |
| frontend/pages/SoftwarePage/components/icons/GrooveOmniDialer.tsx | Adds the Groove OmniDialer icon component (SVG embedding a base64 PNG). |
| ee/maintained-apps/outputs/groove-omnidialer/darwin.json | Adds the generated maintained-app manifest for macOS, including queries, installer metadata, and script refs. |
| ee/maintained-apps/outputs/apps.json | Adds Groove OmniDialer to the maintained apps list surfaced by Fleet. |
| ee/maintained-apps/inputs/homebrew/groove-omnidialer.json | Adds the Homebrew input definition for generating the macOS maintained-app output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Introduce Groove OmniDialer to the maintained apps dataset and UI. Adds a homebrew input (dmg) and an apps.json entry, plus a darwin-specific output with version 26.603.1017, installer URL, sha256, and embedded install/uninstall script refs. Also adds a frontend SVG icon component, registers it in the icons index, and includes the app PNG asset. Install/uninstall scripts handle quitting/relaunching the app and cleaning user data.
Summary by CodeRabbit