Skip to content

Update Fleet-maintained apps - #45954

Merged
allenhouchins merged 1 commit into
mainfrom
fma-2605210024
May 21, 2026
Merged

Update Fleet-maintained apps#45954
allenhouchins merged 1 commit into
mainfrom
fma-2605210024

Conversation

@fleet-release

@fleet-release fleet-release commented May 21, 2026

Copy link
Copy Markdown
Contributor

Automated ingestion of latest Fleet-maintained app data.

Summary by CodeRabbit

  • Chores
    • Updated the maintained app definition for 1Password Windows from version 8.12.12 to 8.12.21, including a new installer download URL and corresponding security checksum for integrity verification. Installation detection logic and uninstallation procedures were also updated to align with the new version.

Review Change Stack

Generated automatically with cmd/maintained-apps.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@github-actions

Copy link
Copy Markdown
Contributor

Script Diff Results

ee/maintained-apps/outputs/1password/windows.json

=== Install Script (no changes) ===
=== Uninstall // 43b5726e -> 9f49925c ===

--- /tmp/old.SDa9lg	2026-05-21 00:27:11.203922925 +0000
+++ /tmp/new.poPKB9	2026-05-21 00:27:11.203922925 +0000
@@ -1,7 +1,7 @@
 # 1Password Uninstall Script
 # Closes running processes before uninstalling to prevent hangs
 
-$product_code = '{4E29828B-8BA2-452F-91A1-D4294DC6C0A8}'
+$product_code = '{2385DFA4-343E-42DE-9E7A-D41189885BD7}'
 $timeoutSeconds = 300  # 5 minute timeout
 
 # Close any running 1Password processes

@coderabbitai

coderabbitai Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9ddf2762-15c0-42a8-88b9-58efaff3a2c6

📥 Commits

Reviewing files that changed from the base of the PR and between 48b32e6 and a7e2650.

📒 Files selected for processing (1)
  • ee/maintained-apps/outputs/1password/windows.json

Walkthrough

This PR updates the Windows 1Password maintained app definition from version 8.12.12 to 8.12.21. The change includes the new MSI installer URL and SHA-256 checksum for version 8.12.21, updates the SQL query threshold in the patch detection logic to reference the new version, and replaces the uninstall script reference with a new script ID that contains updated uninstall PowerShell logic with a different 1Password product code GUID. The install script reference remains unchanged.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is minimal and lacks required sections from the template; it does not address testing, validation, checklist items, or provide context about what apps were updated and why. Complete the PR description template including related issue, relevant checklist items (e.g., testing, validation), and specify which apps were updated and the rationale for the changes.
Title check ❓ Inconclusive The title 'Update Fleet-maintained apps' is generic and vague, using non-descriptive language that doesn't convey the specific change (1Password Windows update from 8.12.12 to 8.12.21). Consider a more specific title like 'Update 1Password Windows to 8.12.21' or 'Bump 1Password Windows version to 8.12.21' to clearly indicate the main change.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fma-2605210024

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants