Skip to content

Update Fleet-maintained apps - #45974

Closed
fleet-release wants to merge 1 commit into
mainfrom
fma-2605211314
Closed

Update Fleet-maintained apps#45974
fleet-release wants to merge 1 commit into
mainfrom
fma-2605211314

Conversation

@fleet-release

@fleet-release fleet-release commented May 21, 2026

Copy link
Copy Markdown
Contributor

Automated ingestion of latest Fleet-maintained app data.

Summary by CodeRabbit

  • Bug Fixes
    • Updated 1Password version support to 8.12.21.

Review Change Stack

Generated automatically with cmd/maintained-apps.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 38ce8da5-235d-4bf3-a757-b265098272b4

📥 Commits

Reviewing files that changed from the base of the PR and between a829900 and 34415cd.

📒 Files selected for processing (1)
  • ee/maintained-apps/outputs/1password/darwin.json

Walkthrough

This PR updates the 1Password macOS maintained-app definition to target version 8.12.21. The change updates the versions[0] entry and adjusts the queries.patched SQL condition to compare against the new target version string '8.12.21' instead of '8.12.12', ensuring the patch status check aligns with the updated target version.

Possibly related PRs

  • fleetdm/fleet#45972: Also updates ee/maintained-apps/outputs/1password/darwin.json with the same version bump to 8.12.21 and matching SQL patch query adjustment.
  • fleetdm/fleet#45954: Updates 1Password Windows configuration (windows.json) with the same version target and SQL patch query pattern for version 8.12.21.
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is minimal and lacks required details; it doesn't follow the template structure, missing critical sections like related issue, checklist items, testing notes, and change file documentation. Expand the description to follow the provided template, including the related issue number, completed checklist items for changes files, and testing confirmation.
Title check ❓ Inconclusive The title 'Update Fleet-maintained apps' is vague and generic, using broad terminology that doesn't convey the specific change (1Password version update from 8.12.12 to 8.12.21). Provide a more specific title like 'Update 1Password to version 8.12.21' or 'Bump 1Password version in Fleet-maintained apps' to clearly indicate the specific version change.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fma-2605211314

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown
Contributor

Closing in favor of #45989.

@github-actions github-actions Bot closed this May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants