Skip to content

Update Fleet-maintained apps - #46055

Merged
allenhouchins merged 1 commit into
mainfrom
fma-2605221357
May 22, 2026
Merged

Update Fleet-maintained apps#46055
allenhouchins merged 1 commit into
mainfrom
fma-2605221357

Conversation

@fleet-release

@fleet-release fleet-release commented May 22, 2026

Copy link
Copy Markdown
Contributor

Automated ingestion of latest Fleet-maintained app data.

Summary by CodeRabbit

  • Chores
    • Updated 1Password version detection to recognize version 8.12.21 as patched.

Review Change Stack

Generated automatically with cmd/maintained-apps.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented May 22, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 633307f7-ac32-412a-8a78-aed105284eae

📥 Commits

Reviewing files that changed from the base of the PR and between f60b87d and 18cbdd1.

📒 Files selected for processing (1)
  • ee/maintained-apps/outputs/1password/darwin.json

Walkthrough

This PR updates the 1Password macOS maintained app configuration by bumping the version from 8.12.12 to 8.12.21. The corresponding SQL patched version comparison predicate in queries.patched is updated to match, ensuring the version check targets the new 8.12.21 threshold.

Possibly related PRs

  • fleetdm/fleet#45954: Updates 1Password maintained app definition to version 8.12.21 across platform-specific JSON files.
  • fleetdm/fleet#46050: Updates the same darwin.json file bumping 1Password to 8.12.21 with matching SQL version_compare adjustment.
  • fleetdm/fleet#45972: Bumps 1Password version from 8.12.12 to 8.12.21 with corresponding SQL patched version threshold update.
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Update Fleet-maintained apps' is generic and vague, using broad terminology that doesn't convey specific details about the actual change. Consider a more specific title like 'Update 1Password to version 8.12.21 in maintained apps' to clearly communicate the primary change.
Description check ❓ Inconclusive The description 'Automated ingestion of latest Fleet-maintained app data' is vague and generic, failing to provide specific details about what was updated or why. Expand the description to specify which apps were updated, their new versions, and any relevant context, rather than using generic language.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fma-2605221357

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@allenhouchins
allenhouchins merged commit f413df0 into main May 22, 2026
12 of 13 checks passed
@allenhouchins
allenhouchins deleted the fma-2605221357 branch May 22, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants