Adding changes for Fleet v4.84.1 by georgekarrv · Pull Request #44525 · fleetdm/fleet

georgekarrv · 2026-04-30T18:30:29Z

Summary by CodeRabbit

Chores
- Updated Fleet version from v4.84.0 to v4.84.1 across deployment configurations (Helm values, container images, Terraform for AWS/GCP, and npm package) and bumped Helm chart package version v6.9.1 → v6.9.2.
Documentation
- Updated CLI help/example text to reference the v4.84.1 milestone.

claude

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

_{Tip: disable this comment in your organization's Code Review settings.}

coderabbitai · 2026-04-30T18:35:50Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: fdca0f6a-a45d-4678-b3b9-667de06b3fc7

📥 Commits

Reviewing files that changed from the base of the PR and between 728795f1cfa207c2391234070c2a6a6e59bad9fc and 4faaca8.

⛔ Files ignored due to path filters (1)

CHANGELOG.md is excluded by !**/*.md

📒 Files selected for processing (6)

charts/fleet/Chart.yaml
charts/fleet/values.yaml
infrastructure/dogfood/terraform/aws/variables.tf
infrastructure/dogfood/terraform/gcp/variables.tf
tools/fleetctl-npm/package.json
tools/github-manage/cmd/gm/releases.go

✅ Files skipped from review due to trivial changes (6)

charts/fleet/values.yaml
infrastructure/dogfood/terraform/aws/variables.tf
infrastructure/dogfood/terraform/gcp/variables.tf
tools/fleetctl-npm/package.json
tools/github-manage/cmd/gm/releases.go
charts/fleet/Chart.yaml

Walkthrough

This PR increments Fleet-related versions from v4.84.0 to v4.84.1 across deployment and tooling references: Helm chart metadata (charts/fleet/Chart.yaml version v6.9.1→v6.9.2 and appVersion v4.84.0→v4.84.1), Helm values imageTag, Terraform default image variables for dogfood AWS and GCP, the npm package tools/fleetctl-npm/package.json version, and an example --milestone help string in tools/github-manage/cmd/gm/releases.go. No functional logic changes.

Possibly related PRs

Adding changes for Fleet v4.83.2 #43495: Modifies the same configuration files and fields (Helm Chart.yaml/values, Terraform image variables, npm package) to bump Fleet app/image versions.
Adding changes for Fleet v4.83.1 #43357: Performs equivalent version bumps across the same files and locations, updating Fleet versions in charts, Terraform, npm package, and related help text.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request description is entirely missing; the author provided no description at all, leaving it blank.	Add a pull request description explaining the purpose of the version bump, what was changed, and any relevant testing or validation performed.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title correctly identifies the main purpose of the changeset: preparing version v4.84.1 by updating version references across multiple files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch update-changelog-prepare-4.84.1-main

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

Updates Fleet release artifacts and deployment defaults to align with the Fleet v4.84.1 release, including Helm chart metadata and dogfood Terraform image tags.

Changes:

Bumped Fleet version references from v4.84.0 → v4.84.1 across tooling, Helm, and dogfood Terraform.
Incremented Helm chart version v6.9.1 → v6.9.2 and updated appVersion to v4.84.1.
Added a new Fleet 4.84.1 section to CHANGELOG.md.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tools/github-manage/cmd/gm/releases.go	Updates the example milestone for the `gm releases forecast` command to 4.84.1.
tools/fleetctl-npm/package.json	Bumps fleetctl npm installer package version to v4.84.1.
infrastructure/dogfood/terraform/gcp/variables.tf	Updates dogfood GCP default Fleet image tag to v4.84.1.
infrastructure/dogfood/terraform/aws/variables.tf	Updates dogfood AWS default Fleet image tag to v4.84.1.
charts/fleet/values.yaml	Updates default Helm image tag to v4.84.1.
charts/fleet/Chart.yaml	Bumps chart version and updates `appVersion` to v4.84.1.
CHANGELOG.md	Adds 4.84.1 changelog entry and adjusts one existing bullet formatting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+- Fixed a bug where host environment variables in script-only packages would cause gitops to fail
+- Updated go to 1.26.2
+- Fixed SCEP renewals not retrying after initial failure
+- Extend SCEP enrollment/renewal challenge credential TTL


+- Updated go to 1.26.2
+- Fixed SCEP renewals not retrying after initial failure
+- Extend SCEP enrollment/renewal challenge credential TTL
+- Fixed an issue where trying to wipe a device after its certificate was renewed could fail due to a missing bootstrap token. _Note: The device might still have wiped_


@@ -82,7 +97,7 @@
 - Fixed issue where the `include_available_for_install` query param wasn't being applied correctly to the `GET /api/latest/fleet/hosts/{id}/software` endpoint.
 - Fixed disk encryption key modal to not show stale key when switching between hosts.
 - Fixed SCIM user not associating with host when IdP username was set before the SCIM user was created.
- Fixed Google Drive version not matching upstream.
+- Fixed  Google Drive version not matching upstream.


codecov · 2026-04-30T18:55:33Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.76%. Comparing base (be3b02d) to head (4faaca8).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #44525      +/-   ##
==========================================
- Coverage   66.78%   66.76%   -0.03%     
==========================================
  Files        2637     2637              
  Lines      212092   212186      +94     
  Branches     9518     9518              
==========================================
+ Hits       141653   141665      +12     
- Misses      57576    57676     +100     
+ Partials    12863    12845      -18

Flag	Coverage Δ
backend	`68.53% <ø> (-0.03%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: George Karr <georgekarrv@users.noreply.github.com>

## Summary by CodeRabbit * **Chores** * Updated Fleet version from v4.84.0 to v4.84.1 across deployment configurations (Helm values, container images, Terraform for AWS/GCP, and npm package) and bumped Helm chart package version v6.9.1 → v6.9.2. * **Documentation** * Updated CLI help/example text to reference the v4.84.1 milestone.

Copilot AI review requested due to automatic review settings April 30, 2026 18:30

georgekarrv requested review from a team, BCTBB, ddribeiro, rfairburn and rynsatterlee as code owners April 30, 2026 18:30

fleet-release requested a review from lukeheath April 30, 2026 18:30

claude Bot reviewed Apr 30, 2026

View reviewed changes

georgekarrv temporarily deployed to Docker Hub April 30, 2026 18:30 — with GitHub Actions Inactive

Copilot started reviewing on behalf of georgekarrv April 30, 2026 18:35 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Adding changes for Fleet v4.84.1

4faaca8

georgekarrv force-pushed the update-changelog-prepare-4.84.1-main branch from 728795f to 4faaca8 Compare May 1, 2026 04:08

georgekarrv temporarily deployed to Docker Hub May 1, 2026 04:08 — with GitHub Actions Inactive

georgekarrv commented May 1, 2026

View reviewed changes

Comment thread CHANGELOG.md Outdated

Apply suggestion from @georgekarrv

459fb55

georgekarrv had a problem deploying to Docker Hub May 1, 2026 14:17 — with GitHub Actions Error

georgekarrv commented May 1, 2026

View reviewed changes

Comment thread tools/github-manage/cmd/gm/releases.go Outdated

georgekarrv commented May 1, 2026

View reviewed changes

Comment thread tools/github-manage/cmd/gm/releases.go Outdated

Apply suggestions from code review

60daa5f

Co-authored-by: George Karr <georgekarrv@users.noreply.github.com>

georgekarrv temporarily deployed to Docker Hub May 1, 2026 14:17 — with GitHub Actions Inactive

BCTBB approved these changes May 1, 2026

View reviewed changes

georgekarrv merged commit a83d453 into main May 1, 2026
17 checks passed

georgekarrv deleted the update-changelog-prepare-4.84.1-main branch May 1, 2026 14:27

This was referenced May 1, 2026

Adding changes for Fleet v4.84.2 #44590

Merged

Adding changes for Fleet v4.84.3 #44886

Merged

coderabbitai Bot mentioned this pull request May 21, 2026

Adding changes for Fleet v4.85.1 #46015

Merged

coderabbitai Bot mentioned this pull request Jun 1, 2026

Adding changes for Fleet v4.86.1 #46610

Merged

Navigation Menu

Uh oh!

Adding changes for Fleet v4.84.1 - #44525

Adding changes for Fleet v4.84.1#44525
georgekarrv merged 3 commits into
mainfrom
update-changelog-prepare-4.84.1-main

georgekarrv commented Apr 30, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

claude Bot left a comment

Uh oh!

coderabbitai Bot commented Apr 30, 2026 •

edited

Loading

❌ Failed checks (2 warnings)

Uh oh!

Copilot AI left a comment

Uh oh!

codecov Bot commented Apr 30, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

georgekarrv commented Apr 30, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

claude Bot left a comment

Choose a reason for hiding this comment

Claude Code Review

Uh oh!

coderabbitai Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

❌ Failed checks (2 warnings)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

codecov Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

georgekarrv commented Apr 30, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 30, 2026 •

edited

Loading

codecov Bot commented Apr 30, 2026 •

edited

Loading