Adding changes for Fleet v4.86.1 - #46610
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThis PR performs a coordinated patch version bump from v4.86.0 to v4.86.1 across the Fleet project's deployment and CLI tooling. The Helm chart version is incremented to v7.0.6 with appVersion updated to v4.86.1. The Helm values configuration, AWS and GCP Terraform dogfood infrastructure variables, and the npm package manifest all reference the updated v4.86.1 container image tag. Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates release-related references across tooling, deployment configs, and documentation for the Fleet v4.86.1 release.
Changes:
- Bumped Fleet version references to v4.86.1 across dogfood Terraform and the Helm chart (including chart version/appVersion).
- Updated internal tooling documentation/examples (
migration-cleanup,gm releases forecast) to reference 4.86.1. - Added a Fleet 4.86.1 entry to
CHANGELOG.md.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/migration-cleanup/README.md | Updates example RC branch references to v4.86.1 (needs a small internal consistency fix in the example text). |
| tools/github-manage/cmd/gm/releases.go | Updates the example milestone text for the gm releases forecast command to 4.86.1. |
| tools/fleetctl-npm/package.json | Bumps the fleetctl npm package version to v4.86.1. |
| infrastructure/dogfood/terraform/gcp/variables.tf | Updates dogfood GCP default Fleet image tag to v4.86.1. |
| infrastructure/dogfood/terraform/aws/variables.tf | Updates dogfood AWS default Fleet image tag to v4.86.1. |
| charts/fleet/values.yaml | Updates the default Helm chart imageTag to v4.86.1. |
| charts/fleet/Chart.yaml | Bumps Helm chart version and appVersion for v4.86.1. |
| CHANGELOG.md | Adds a Fleet 4.86.1 changelog entry (minor list marker consistency issue). |
Comments suppressed due to low confidence (1)
tools/migration-cleanup/README.md:113
- This example section header was updated to
rc-minor-fleet-v4.86.1, but the body text still refers to “4.86 RC migrations”. Update the remaining references in this example to 4.86.1 to keep the documentation internally consistent.
## Example: rc-minor-fleet-v4.86.1
This was the move-up renumber case tested against a local MySQL database that
had already run the pre-renumber 4.86 RC migrations. Running the latest RC
binary against that database failed while rerunning a migration that had already
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #46610 +/- ##
=======================================
Coverage 66.87% 66.87%
=======================================
Files 2814 2814
Lines 223913 223913
Branches 11518 11518
=======================================
+ Hits 149739 149753 +14
+ Misses 60584 60574 -10
+ Partials 13590 13586 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: George Karr <georgekarrv@users.noreply.github.com>
|
|
||
| The normal target is the RC branch that contains the final, renumbered migration | ||
| filenames, such as `rc-minor-fleet-v4.86.0` or `rc-patch-fleet-v4.73.2`. The | ||
| filenames, such as `rc-minor-fleet-v4.86.1` or `rc-patch-fleet-v4.73.2`. The |
There was a problem hiding this comment.
| filenames, such as `rc-minor-fleet-v4.86.1` or `rc-patch-fleet-v4.73.2`. The | |
| filenames, such as `rc-minor-fleet-v4.86.0` or `rc-patch-fleet-v4.73.2`. The |
|
|
||
| ```sh | ||
| go run ./tools/migration-cleanup -b rc-minor-fleet-v4.86.0 | ||
| go run ./tools/migration-cleanup -b rc-minor-fleet-v4.86.1 |
There was a problem hiding this comment.
| go run ./tools/migration-cleanup -b rc-minor-fleet-v4.86.1 | |
| go run ./tools/migration-cleanup -b rc-minor-fleet-v4.86.0 |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Summary by CodeRabbit