Adding changes for Fleet v4.84.2 by georgekarrv · Pull Request #44590 · fleetdm/fleet

georgekarrv · 2026-05-01T15:07:35Z

Summary by CodeRabbit

Chores
- Version bumped to v4.84.2 across Helm charts, container images, deployment infrastructure, and npm package.

claude

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

_{Tip: disable this comment in your organization's Code Review settings.}

coderabbitai · 2026-05-01T15:09:22Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9c1b531a-9914-4199-9c8b-33411a214d40

📥 Commits

Reviewing files that changed from the base of the PR and between fab3af3 and 4af417b.

⛔ Files ignored due to path filters (1)

CHANGELOG.md is excluded by !**/*.md

📒 Files selected for processing (5)

charts/fleet/Chart.yaml
charts/fleet/values.yaml
infrastructure/dogfood/terraform/aws/variables.tf
infrastructure/dogfood/terraform/gcp/variables.tf
tools/fleetctl-npm/package.json

Walkthrough

This PR bumps the Fleet application version from v4.84.1 to v4.84.2 across multiple deployment and distribution artifacts. The chart version is incremented from v6.9.2 to v6.9.3 in the Helm Chart.yaml metadata. The image tag is updated in the Helm values.yaml file, the Terraform variables for both AWS and GCP dogfood environments, and the npm package metadata for fleetctl-npm.

Possibly related PRs

#43357: Makes identical per-file metadata and image-version bumps across Chart.yaml, values.yaml, Terraform variables, and npm package.json.
#44525: Modifies the same Helm chart, values, Terraform variables, and npm package version fields to bump Fleet app/image versions.
#43495: Makes the same set of metadata and image-version updates across Chart.yaml, values.yaml, Terraform variables, and package.json files.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	No pull request description was provided by the author; the required template sections are entirely missing.	Add a pull request description following the repository template, including related issue reference and relevant checklist items for version updates.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: bumping Fleet to version v4.84.2 across multiple configuration files and packages.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch update-changelog-prepare-4.84.2-main

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

Updates the repo’s published version references for the Fleet v4.84.2 release across packaging/deployment artifacts, and adds the v4.84.2 changelog entry.

Changes:

Bump fleetctl npm installer package version to v4.84.2.
Update dogfood Terraform defaults (AWS/GCP) and Helm chart values/metadata to deploy Fleet v4.84.2.
Add 4.84.2 release notes to CHANGELOG.md.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
tools/fleetctl-npm/package.json	Bumps the published `fleetctl` npm package version to v4.84.2.
infrastructure/dogfood/terraform/gcp/variables.tf	Updates the default Fleet container image tag used by GCP dogfood.
infrastructure/dogfood/terraform/aws/variables.tf	Updates the default Fleet container image tag used by AWS dogfood.
charts/fleet/values.yaml	Updates the default Helm-deployed Fleet image tag to v4.84.2.
charts/fleet/Chart.yaml	Bumps Helm chart version and appVersion to align with Fleet v4.84.2.
CHANGELOG.md	Adds the Fleet 4.84.2 section and adjusts one existing bullet indentation (with a spacing issue).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-05-01T15:14:32Z

@@ -1,3 +1,18 @@
+## Fleet 4.84.2 (May 01, 2026)


The release date uses a leading zero ("May 01, 2026"), which is inconsistent with nearby entries (e.g., "Apr 30, 2026"). Consider changing to "May 1, 2026" for consistency.

Suggested change

## Fleet 4.84.2 (May 01, 2026)

## Fleet 4.84.2 (May 1, 2026)

Copilot · 2026-05-01T15:14:33Z

+
+- Fixed filtering in `/api/v1/fleet/labels/:id/hosts` endpoint.
+- Fixed a dead SQL condition in `hostVPPInstalls` that was misleading but harmless: Android VPP apps never produce `nano_command_results` entries (they use Google's Android Management API, not nanoMDM), so the previous `(hvsi.platform != 'android' OR ncr.id IS NULL)` guard was a tautology. Replaced with a clarifying comment.
+- Fleet UI > Settings > Variables: Fixed access to not allow adding custom variable while in gitops mode both in the empty state and when a variable already exists


This bullet is grammatically hard to parse and is missing terminal punctuation. Consider rewording to clearly describe the access control change (e.g., preventing adding custom variables while in GitOps mode) and end the sentence with a period.

Suggested change

- Fleet UI > Settings > Variables: Fixed access to not allow adding custom variable while in gitops mode both in the empty state and when a variable already exists

- Fleet UI > Settings > Variables: Prevented adding custom variables while in GitOps mode, both in the empty state and when a variable already exists.

Copilot · 2026-05-01T15:14:33Z

+- Fixed a bug where custom package installers were not removed when adding an FMA for the same title via GitOps, which caused setup experience to install duplicate software.
+- Fixed a bug where host environment variables in script-only packages would cause gitops to fail
+- Updated go to 1.26.2
+- Fixed an issue where trying to wipe a device after its certificate was renewed could fail due to a missing bootstrap token. _Note: The device might still have wiped_


The note reads awkwardly ("might still have wiped"); consider changing to "might still have been wiped" for correct tense and clarity.

Suggested change

- Fixed an issue where trying to wipe a device after its certificate was renewed could fail due to a missing bootstrap token. _Note: The device might still have wiped_

- Fixed an issue where trying to wipe a device after its certificate was renewed could fail due to a missing bootstrap token. _Note: The device might still have been wiped_

Copilot · 2026-05-01T15:14:33Z

 - Fixed disk encryption key modal to not show stale key when switching between hosts.
 - Fixed SCIM user not associating with host when IdP username was set before the SCIM user was created.
- Fixed Google Drive version not matching upstream.
+- Fixed  Google Drive version not matching upstream.


There is an extra space after "Fixed" ("Fixed Google Drive..."). Please remove the double space to avoid formatting issues in the rendered changelog.

Suggested change

- Fixed Google Drive version not matching upstream.

- Fixed Google Drive version not matching upstream.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

## Summary by CodeRabbit * **Chores** * Version bumped to v4.84.2 across Helm charts, container images, deployment infrastructure, and npm package.  --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Adding changes for Fleet v4.84.2

4af417b

Copilot AI review requested due to automatic review settings May 1, 2026 15:07

georgekarrv requested review from BCTBB, ddribeiro, rfairburn and rynsatterlee as code owners May 1, 2026 15:07

fleet-release requested a review from lukeheath May 1, 2026 15:07

claude Bot reviewed May 1, 2026

View reviewed changes

georgekarrv temporarily deployed to Docker Hub May 1, 2026 15:07 — with GitHub Actions Inactive

Copilot started reviewing on behalf of georgekarrv May 1, 2026 15:11 View session

Copilot AI reviewed May 1, 2026

View reviewed changes

BCTBB previously approved these changes May 4, 2026

View reviewed changes

Update CHANGELOG.md

e1c5af5

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

georgekarrv dismissed BCTBB’s stale review via e1c5af5 May 4, 2026 15:54

georgekarrv temporarily deployed to Docker Hub May 4, 2026 15:54 — with GitHub Actions Inactive

BCTBB approved these changes May 4, 2026

View reviewed changes

georgekarrv merged commit 499fc89 into main May 4, 2026
17 checks passed

georgekarrv deleted the update-changelog-prepare-4.84.2-main branch May 4, 2026 15:59

This was referenced May 4, 2026

adding redis and mysql subcharts instead of bitnami #42442

Merged

Adding changes for Fleet v4.84.3 #44886

Merged

coderabbitai Bot mentioned this pull request May 21, 2026

Adding changes for Fleet v4.85.1 #46015

Merged

Navigation Menu

Uh oh!

Adding changes for Fleet v4.84.2 - #44590

Adding changes for Fleet v4.84.2#44590
georgekarrv merged 2 commits into
mainfrom
update-changelog-prepare-4.84.2-main

georgekarrv commented May 1, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

claude Bot left a comment

Uh oh!

coderabbitai Bot commented May 1, 2026

❌ Failed checks (1 warning)

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI May 1, 2026

Uh oh!

Copilot AI May 1, 2026

Uh oh!

Copilot AI May 1, 2026

Uh oh!

Copilot AI May 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	- Fleet UI > Settings > Variables: Fixed access to not allow adding custom variable while in gitops mode both in the empty state and when a variable already exists
	- Fleet UI > Settings > Variables: Prevented adding custom variables while in GitOps mode, both in the empty state and when a variable already exists.

	- Fixed an issue where trying to wipe a device after its certificate was renewed could fail due to a missing bootstrap token. _Note: The device might still have wiped_
	- Fixed an issue where trying to wipe a device after its certificate was renewed could fail due to a missing bootstrap token. _Note: The device might still have been wiped_

	- Fixed Google Drive version not matching upstream.
	- Fixed Google Drive version not matching upstream.

Uh oh!

Conversation

georgekarrv commented May 1, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

claude Bot left a comment

Choose a reason for hiding this comment

Claude Code Review

Uh oh!

coderabbitai Bot commented May 1, 2026

Walkthrough

Possibly related PRs

❌ Failed checks (1 warning)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI May 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

georgekarrv commented May 1, 2026 •

edited by coderabbitai Bot

Loading