Move VPP instructions out of UI and into guides - #43641
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Review Summary by QodoMove VPP setup instructions from UI to external guides
WalkthroughsDescription• Remove VPP setup instructions from UI components • Replace inline steps with links to external guides • Add routing for VPP guide links in website config • Clean up unused component exports and styling Diagramflowchart LR
A["VPP UI Components"] -->|Remove inline steps| B["AddVppModal & RenewVppModal"]
B -->|Add guide links| C["CustomLink to guides"]
C -->|Route to| D["website/guides/apple-mdm-setup"]
E["VppSetupSteps Component"] -->|Delete| F["Unused Component"]
File Changes1. frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/VppSetupSteps/index.ts
|
Code Review by Qodo
1.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #43641 +/- ##
=======================================
Coverage 66.90% 66.91%
=======================================
Files 2600 2600
Lines 208430 208361 -69
Branches 9225 9207 -18
=======================================
- Hits 139448 139415 -33
+ Misses 56296 56272 -24
+ Partials 12686 12674 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughRemoved the VppSetupSteps component and its styles. Replaced VppSetupSteps usages in AddVppModal and RenewVppModal with descriptive text that includes CustomLink targets; removed the Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![qodo-free-for-open-source-projects[bot]](https://avatars.githubusercontent.com/in/1068000?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/RenewVppModal/RenewVppModal.tsx (1)
71-71: Consider centralizing the guide URLLine 71 hardcodes the Fleet website URL. Since this link pattern is now part of the UX, consider extracting it to a shared constant to avoid drift if routes/domains change later.
Refactor example
+const RENEW_VPP_GUIDE_URL = "https://fleetdm.com/learn-more-about/renew-vpp"; ... - <CustomLink - url="https://fleetdm.com/learn-more-about/renew-vpp" + <CustomLink + url={RENEW_VPP_GUIDE_URL} text="Learn how" newTab />🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/RenewVppModal/RenewVppModal.tsx` at line 71, The hardcoded guide URL in the RenewVppModal component should be extracted into a shared constant so it can be updated across the app; create (or add to) a central constant like GUIDE_URLS.RENEW_VPP (or a ROUTES/EXTERNAL_LINKS export) and replace the inline string in RenewVppModal.tsx with an import of that constant (update the import in RenewVppModal and any other components that use the same Fleet learn-more URL), ensure the new constant is well-named and documented, and run/update any tests or snapshots that reference the original hardcoded URL.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/RenewVppModal/RenewVppModal.tsx`:
- Line 71: The hardcoded guide URL in the RenewVppModal component should be
extracted into a shared constant so it can be updated across the app; create (or
add to) a central constant like GUIDE_URLS.RENEW_VPP (or a ROUTES/EXTERNAL_LINKS
export) and replace the inline string in RenewVppModal.tsx with an import of
that constant (update the import in RenewVppModal and any other components that
use the same Fleet learn-more URL), ensure the new constant is well-named and
documented, and run/update any tests or snapshots that reference the original
hardcoded URL.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: bb14168c-5186-4f35-9cb0-70693f2d78fc
📒 Files selected for processing (4)
frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/AddVppModal/AddVppModal.tsxfrontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/AddVppModal/_styles.scssfrontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/RenewVppModal/RenewVppModal.tsxfrontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/RenewVppModal/_styles.scss
✅ Files skipped from review due to trivial changes (3)
- frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/AddVppModal/_styles.scss
- frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/RenewVppModal/_styles.scss
- frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/AddVppModal/AddVppModal.tsx
2 participants
Summary by CodeRabbit
New Features
Changes
Style