Missed ABM UI instances - #43506
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #43506 +/- ##
=======================================
Coverage 66.92% 66.92%
=======================================
Files 2598 2598
Lines 208238 208238
Branches 9208 9208
=======================================
Hits 139356 139356
Misses 56219 56219
Partials 12663 12663
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WalkthroughThis pull request updates user-facing text across multiple frontend pages related to Apple Business Manager and VPP integrations. The changes include replacing references to "ABM" with "AB" in the AppleBusinessManagerPage, table configuration tooltips, and modal dialogs. Additionally, instructional text in VppPage and VppSetupSteps components was modified to adjust line breaks, punctuation, and terminology around "Apple Business" naming. All modifications are confined to displayed strings and UI content; no component logic, state management, or exported function signatures were altered. 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
RachelElysia
left a comment
There was a problem hiding this comment.
Thanks @melpike - feel free to tag me to review the cherry-pick
Missed a few AMB UI instances as part of [Rename Apple Business Manager (ABM) to Apple Business (AB) in UI](#42512) <!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** #42512 (comment) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Updated user-facing text and messaging across Apple Business Manager integration pages, including modal titles, instructional content, and setup guides * Refined terminology, formatting, and punctuation throughout tooltip content, administrative configuration descriptions, and user guidance * Adjusted messaging and instructional text in Apple Business Manager and VPP settings pages <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Missed a few AMB UI instances as part of [Rename Apple Business Manager (ABM) to Apple Business (AB) in UI](#42512) <!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:**#43506 #42512 (comment) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Updated user-facing text and messaging across Apple Business Manager integration pages, including modal titles, instructional content, and setup guides * Refined terminology, formatting, and punctuation throughout tooltip content, administrative configuration descriptions, and user guidance * Adjusted messaging and instructional text in Apple Business Manager and VPP settings pages <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves # # Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters. - [ ] Timeouts are implemented and retries are limited to avoid infinite loops - [ ] If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes ## Testing - [ ] Added/updated automated tests - [ ] Where appropriate, [automated tests simulate multiple hosts and test for host isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing) (updates to one hosts's records do not affect another) - [ ] QA'd all new/changed functionality manually For unreleased bug fixes in a release candidate, one of: - [ ] Confirmed that the fix is not expected to adversely impact load test results - [ ] Alerted the release DRI if additional load testing is needed ## Database migrations - [ ] Checked schema for all modified table for columns that will auto-update timestamps during migration. - [ ] Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects. - [ ] Ensured the correct collation is explicitly set for character columns (`COLLATE utf8mb4_unicode_ci`). ## New Fleet configuration settings - [ ] Setting(s) is/are explicitly excluded from GitOps If you didn't check the box above, follow this checklist for GitOps-enabled settings: - [ ] Verified that the setting is exported via `fleetctl generate-gitops` - [ ] Verified the setting is documented in a separate PR to [the GitOps documentation](https://github.com/fleetdm/fleet/blob/main/docs/Configuration/yaml-files.md#L485) - [ ] Verified that the setting is cleared on the server if it is not supplied in a YAML file (or that it is documented as being optional) - [ ] Verified that any relevant UI is disabled when GitOps mode is enabled ## fleetd/orbit/Fleet Desktop - [ ] Verified compatibility with the latest released version of Fleet (see [Must rule](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/workflows/fleetd-development-and-release-strategy.md)) - [ ] If the change applies to only one platform, confirmed that `runtime.GOOS` is used as needed to isolate changes - [ ] Verified that fleetd runs on macOS, Linux and Windows - [ ] Verified auto-update works from the released version of component to the new version (see [tools/tuf/test](../tools/tuf/test/README.md))
Missed a few AMB UI instances as part of Rename Apple Business Manager (ABM) to Apple Business (AB) in UI
Related issue: #42512 (comment)
Summary by CodeRabbit