Skip to content

Missed ABM UI instances - #43506

Merged
melpike merged 1 commit into
mainfrom
melpike-missing-ABM-UI-update
Apr 15, 2026
Merged

Missed ABM UI instances#43506
melpike merged 1 commit into
mainfrom
melpike-missing-ABM-UI-update

Conversation

@melpike

@melpike melpike commented Apr 13, 2026

Copy link
Copy Markdown
Member

Missed a few AMB UI instances as part of Rename Apple Business Manager (ABM) to Apple Business (AB) in UI

Related issue: #42512 (comment)

Summary by CodeRabbit

  • Documentation
    • Updated user-facing text and messaging across Apple Business Manager integration pages, including modal titles, instructional content, and setup guides
    • Refined terminology, formatting, and punctuation throughout tooltip content, administrative configuration descriptions, and user guidance
    • Adjusted messaging and instructional text in Apple Business Manager and VPP settings pages

@melpike
melpike requested a review from a team as a code owner April 13, 2026 22:01

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@codecov

codecov Bot commented Apr 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.92%. Comparing base (2245359) to head (51a517a).
⚠️ Report is 67 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #43506   +/-   ##
=======================================
  Coverage   66.92%   66.92%           
=======================================
  Files        2598     2598           
  Lines      208238   208238           
  Branches     9208     9208           
=======================================
  Hits       139356   139356           
  Misses      56219    56219           
  Partials    12663    12663           
Flag Coverage Δ
frontend 54.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@melpike melpike added the ~unreleased bug This bug was found in an unreleased version of Fleet. label Apr 13, 2026
@coderabbitai

coderabbitai Bot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

This pull request updates user-facing text across multiple frontend pages related to Apple Business Manager and VPP integrations. The changes include replacing references to "ABM" with "AB" in the AppleBusinessManagerPage, table configuration tooltips, and modal dialogs. Additionally, instructional text in VppPage and VppSetupSteps components was modified to adjust line breaks, punctuation, and terminology around "Apple Business" naming. All modifications are confined to displayed strings and UI content; no component logic, state management, or exported function signatures were altered.

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Missed AMB UI instances' is vague and uses abbreviations without context, making it unclear to someone scanning history what the actual changes entail. Replace with a more specific title like 'Replace AMB abbreviation with AB in user-facing text' to clarify the actual nature of the changes.
Description check ❓ Inconclusive PR description is minimal and lacks required checklist items from the template, though it does provide a related issue reference. Complete the PR description by adding the checklist items from the template, particularly: Changes files verification, testing details, and any other applicable sections.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch melpike-missing-ABM-UI-update

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@RachelElysia RachelElysia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @melpike - feel free to tag me to review the cherry-pick

@melpike melpike mentioned this pull request Apr 15, 2026
2 tasks
@melpike
melpike merged commit 13ec567 into main Apr 15, 2026
19 checks passed
@melpike
melpike deleted the melpike-missing-ABM-UI-update branch April 15, 2026 19:52
melpike added a commit that referenced this pull request Apr 15, 2026
Missed a few AMB UI instances as part of [Rename Apple Business Manager
(ABM) to Apple Business (AB) in
UI](#42512)

<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:**
#42512 (comment)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Documentation**
* Updated user-facing text and messaging across Apple Business Manager
integration pages, including modal titles, instructional content, and
setup guides
* Refined terminology, formatting, and punctuation throughout tooltip
content, administrative configuration descriptions, and user guidance
* Adjusted messaging and instructional text in Apple Business Manager
and VPP settings pages

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@melpike melpike mentioned this pull request Apr 15, 2026
21 tasks
melpike added a commit that referenced this pull request Apr 15, 2026
Missed a few AMB UI instances as part of [Rename Apple Business Manager
(ABM) to Apple Business (AB) in
UI](#42512)

<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:**#43506
#42512 (comment)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Documentation**
* Updated user-facing text and messaging across Apple Business Manager
integration pages, including modal titles, instructional content, and
setup guides
* Refined terminology, formatting, and punctuation throughout tooltip
content, administrative configuration descriptions, and user guidance
* Adjusted messaging and instructional text in Apple Business Manager
and VPP settings pages

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [ ] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files)
for more information.

- [ ] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements), JS
inline code is prevented especially for url redirects, and untrusted
data interpolated into shell scripts/commands is validated against shell
metacharacters.
- [ ] Timeouts are implemented and retries are limited to avoid infinite
loops
- [ ] If paths of existing endpoints are modified without backwards
compatibility, checked the frontend/CLI for any necessary changes

## Testing

- [ ] Added/updated automated tests
- [ ] Where appropriate, [automated tests simulate multiple hosts and
test for host
isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing)
(updates to one hosts's records do not affect another)

- [ ] QA'd all new/changed functionality manually

For unreleased bug fixes in a release candidate, one of:

- [ ] Confirmed that the fix is not expected to adversely impact load
test results
- [ ] Alerted the release DRI if additional load testing is needed

## Database migrations

- [ ] Checked schema for all modified table for columns that will
auto-update timestamps during migration.
- [ ] Confirmed that updating the timestamps is acceptable, and will not
cause unwanted side effects.
- [ ] Ensured the correct collation is explicitly set for character
columns (`COLLATE utf8mb4_unicode_ci`).

## New Fleet configuration settings

- [ ] Setting(s) is/are explicitly excluded from GitOps

If you didn't check the box above, follow this checklist for
GitOps-enabled settings:

- [ ] Verified that the setting is exported via `fleetctl
generate-gitops`
- [ ] Verified the setting is documented in a separate PR to [the GitOps
documentation](https://github.com/fleetdm/fleet/blob/main/docs/Configuration/yaml-files.md#L485)
- [ ] Verified that the setting is cleared on the server if it is not
supplied in a YAML file (or that it is documented as being optional)
- [ ] Verified that any relevant UI is disabled when GitOps mode is
enabled

## fleetd/orbit/Fleet Desktop

- [ ] Verified compatibility with the latest released version of Fleet
(see [Must
rule](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/workflows/fleetd-development-and-release-strategy.md))
- [ ] If the change applies to only one platform, confirmed that
`runtime.GOOS` is used as needed to isolate changes
- [ ] Verified that fleetd runs on macOS, Linux and Windows
- [ ] Verified auto-update works from the released version of component
to the new version (see [tools/tuf/test](../tools/tuf/test/README.md))
@melpike melpike changed the title Missed AMB UI instances Missed ABM UI instances Apr 20, 2026
@coderabbitai coderabbitai Bot mentioned this pull request Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

~unreleased bug This bug was found in an unreleased version of Fleet.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants