Skip to content

Move APNs instructions out of UI and into guides - #43434

Merged
noahtalerman merged 3 commits into
mainfrom
move-apns-instructions
Apr 15, 2026
Merged

Move APNs instructions out of UI and into guides#43434
noahtalerman merged 3 commits into
mainfrom
move-apns-instructions

Conversation

@noahtalerman

@noahtalerman noahtalerman commented Apr 10, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Style

    • Updated layout alignment and spacing for Apple MDM certificate setup and renewal screens.
  • Refactor

    • Simplified in-app certificate setup instructions to link to external guides instead of displaying step-by-step instructions inline.
    • Updated documentation route redirect for Apple MDM renewal guidance.

@codecov

codecov Bot commented Apr 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.89%. Comparing base (2078e82) to head (79d3e41).
⚠️ Report is 95 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #43434    +/-   ##
========================================
  Coverage   66.89%   66.89%            
========================================
  Files        2594     2594            
  Lines      207757   207757            
  Branches     9211     9325   +114     
========================================
  Hits       138973   138973            
  Misses      56143    56143            
  Partials    12641    12641            
Flag Coverage Δ
frontend 54.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@noahtalerman
noahtalerman marked this pull request as ready for review April 10, 2026 21:33
@noahtalerman
noahtalerman requested a review from a team as a code owner April 10, 2026 21:33

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

This PR simplifies the Apple MDM setup and renewal certificate workflows by removing step-by-step instructional text from two UI components and replacing it with links to an external Fleet guide. The ApplePushCertSetup.tsx and RenewCertModal.tsx components now display a single description sentence directing users to a guide instead of inline ordered instructions. The DownloadCSR and FileUploader components are repositioned within the layout, and SCSS styling is updated to reflect the new flex-based positioning and spacing requirements. Additionally, a legacy redirect URL for APNs renewal documentation is corrected to point to the appropriate guide anchor.

Possibly related issues

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description lacks required sections including checklist items, testing details, and proper issue reference format. Complete the PR description template by adding the 'Related issue' field properly, filling out relevant checklist items, and adding Testing, Database migrations, and other applicable sections.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The PR title accurately summarizes the main change: moving APNs instructions from the UI into guides documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch move-apns-instructions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@noahtalerman
noahtalerman merged commit 1fe982a into main Apr 15, 2026
21 checks passed
@noahtalerman
noahtalerman deleted the move-apns-instructions branch April 15, 2026 19:44
### Renew APNs

1. In Fleet, navigate to the **Settings > Integrations > Mobile device management (MDM)** page.
2. Select **Renew certificate** under the Apple (macOS, iOS, iPadOS) MDM section.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this accurate? As of 4.84 at least, you have to click "Edit" first before you can get to "Renew certificate"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right! Good catch. Opened a follow up PR: #43632

noahtalerman added a commit that referenced this pull request Apr 20, 2026
…out of UI and into guides (#43813)

## Cherry-picks for 4.84 RC

- 1fe982a Move APNs instructions out of UI and into guides (#43434)
- 51af71f Move VPP instructions out of UI and into guides (#43641)
- fa796cd Move Apple Business instructions out of UI and into guides
(#43638)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants