Skip to content

Missed ABM UI instances (#43506) - #43633

Merged
melpike merged 1 commit into
rc-minor-fleet-v4.84.0from
mel-cherry-pick-43506
Apr 15, 2026
Merged

Missed ABM UI instances (#43506)#43633
melpike merged 1 commit into
rc-minor-fleet-v4.84.0from
mel-cherry-pick-43506

Conversation

@melpike

@melpike melpike commented Apr 15, 2026

Copy link
Copy Markdown
Member

Missed a few AMB UI instances as part of Rename Apple Business Manager (ABM) to Apple Business (AB) in
UI

**Related issue:**#43506
#42512 (comment)

Summary by CodeRabbit

  • Documentation
  • Updated user-facing text and messaging across Apple Business Manager integration pages, including modal titles, instructional content, and setup guides
  • Refined terminology, formatting, and punctuation throughout tooltip content, administrative configuration descriptions, and user guidance
  • Adjusted messaging and instructional text in Apple Business Manager and VPP settings pages

Related issue: Resolves #

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters.

  • Timeouts are implemented and retries are limited to avoid infinite loops

  • If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes

Testing

For unreleased bug fixes in a release candidate, one of:

  • Confirmed that the fix is not expected to adversely impact load test results
  • Alerted the release DRI if additional load testing is needed

Database migrations

  • Checked schema for all modified table for columns that will auto-update timestamps during migration.
  • Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.
  • Ensured the correct collation is explicitly set for character columns (COLLATE utf8mb4_unicode_ci).

New Fleet configuration settings

  • Setting(s) is/are explicitly excluded from GitOps

If you didn't check the box above, follow this checklist for GitOps-enabled settings:

  • Verified that the setting is exported via fleetctl generate-gitops
  • Verified the setting is documented in a separate PR to the GitOps documentation
  • Verified that the setting is cleared on the server if it is not supplied in a YAML file (or that it is documented as being optional)
  • Verified that any relevant UI is disabled when GitOps mode is enabled

fleetd/orbit/Fleet Desktop

  • Verified compatibility with the latest released version of Fleet (see Must rule)
  • If the change applies to only one platform, confirmed that runtime.GOOS is used as needed to isolate changes
  • Verified that fleetd runs on macOS, Linux and Windows
  • Verified auto-update works from the released version of component to the new version (see tools/tuf/test)

Missed a few AMB UI instances as part of [Rename Apple Business Manager
(ABM) to Apple Business (AB) in
UI](#42512)

<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:**
#42512 (comment)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Documentation**
* Updated user-facing text and messaging across Apple Business Manager
integration pages, including modal titles, instructional content, and
setup guides
* Refined terminology, formatting, and punctuation throughout tooltip
content, administrative configuration descriptions, and user guidance
* Adjusted messaging and instructional text in Apple Business Manager
and VPP settings pages

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@melpike
melpike requested a review from a team as a code owner April 15, 2026 20:08

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@codecov

codecov Bot commented Apr 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (rc-minor-fleet-v4.84.0@da2080b). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                    @@
##             rc-minor-fleet-v4.84.0   #43633   +/-   ##
=========================================================
  Coverage                          ?   66.85%           
=========================================================
  Files                             ?     2579           
  Lines                             ?   206773           
  Branches                          ?     9158           
=========================================================
  Hits                              ?   138245           
  Misses                            ?    55981           
  Partials                          ?    12547           
Flag Coverage Δ
frontend 54.77% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@melpike
melpike merged commit ba543f2 into rc-minor-fleet-v4.84.0 Apr 15, 2026
16 checks passed
@melpike
melpike deleted the mel-cherry-pick-43506 branch April 15, 2026 23:04
@melpike melpike mentioned this pull request Apr 20, 2026
2 tasks
@melpike melpike changed the title Missed AMB UI instances (#43506) Missed ABM UI instances (#43506) Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants